Skip to content

Enable arrow up/down for all instances of param editor #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pft wants to merge 1 commit into
base: vangelis
Choose a base branch
from
Open

Enable arrow up/down for all instances of param editor #555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions zyngui/zynthian_gui_mixer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2141,7 +2141,9 @@ def arrow_right(self):
def arrow_up(self, nudge=1):
""" Function to handle CUIA ARROW_UP
"""
if self.launcher_mode:
if self.param_editor_zctrl:
self.zynpot_cb(self.ctrl_order[3], 1)
elif self.launcher_mode:
if self.zynseq.phrase > 0:
if self.moving_phrase:
self.zynseq.swap_phrase(self.zynseq.scene, self.zynseq.phrase, self.zynseq.phrase - nudge)
Expand All @@ -2156,7 +2158,9 @@ def arrow_up(self, nudge=1):
def arrow_down(self, nudge=-1):
""" Function to handle CUIA ARROW_DOWN
"""
if self.launcher_mode:
if self.param_editor_zctrl:
self.zynpot_cb(self.ctrl_order[3], -1)
elif self.launcher_mode:
if self.zynseq.phrase < self.zynseq.phrases:
if self.moving_phrase:
if self.zynseq.phrase < self.zynseq.phrases - 1:
Expand Down
11 changes: 9 additions & 2 deletions zyngui/zynthian_gui_selector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ def __init__(self, selcap='Select', wide=False, loading_anim=True, tiny_ctrls=Tr
if "ctrl_width" not in self.layout:
self.layout['ctrl_width'] = 0.25

self.ctrl_order = zynthian_gui_config.layout['ctrl_order']
self.index = 0
self.scroll_y = 0
self.list_data = []
Expand Down Expand Up @@ -421,10 +422,16 @@ def zynpot_cb(self, i, dval):
return False

def arrow_up(self):
self.select(self.index - 1)
if self.param_editor_zctrl:
self.zynpot_cb(self.ctrl_order[3], 1)
else:
self.select(self.index - 1)

def arrow_down(self):
self.select(self.index + 1)
if self.param_editor_zctrl:
self.zynpot_cb(self.ctrl_order[3], -1)
else:
self.select(self.index + 1)

# --------------------------------------------------------------------------
# Keyboard & Mouse/Touch Callbacks
Expand Down