chore: add linux instructions and C++ #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pabloogc
force-pushed
the
linux-gpu-instructions
branch
from
1610b60 to
be71bc1
Compare
Co-authored-by: BW-Projects
pabloogc
force-pushed
the
linux-gpu-instructions
branch
from
be71bc1 to
1f8ff09
Compare
imartinez
previously approved these changes
Oct 20, 2023
pabloogc
changed the title
imartinez
reviewed
Oct 20, 2023
docs/description.md
Outdated
| @@ -74,6 +74,8 @@ pyenv install 3.11 | |||
| pyenv local 3.11 | |||
| ``` | |||
| * Install [Poetry](https://python-poetry.org/docs/#installing-with-the-official-installer) for dependency management: | |||
|
|
|||
| * Install a C++ compiler. See [Troubleshooting: C++ Compiler](#troubleshooting-c-compiler) for more details. | |||
There was a problem hiding this comment.
Does this apply to all platforms? Or only Windows? How can a user check if already has a C++ compiler installed?
There was a problem hiding this comment.
Where is troubleshooting-c-compiler section?
There was a problem hiding this comment.
there is too many ways to configure a C++ compiler, I guess if you don't know if you have it most likely you don't
There was a problem hiding this comment.
About the link, it's down below in the readme
imartinez
approved these changes
Oct 20, 2023
pabloogc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1083