Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kurdish (Kurmanjî dialect) Language support #289

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ozgursarikamis
Copy link

Kurdish (Kurmanjî dialect) Language support

@MrWook MrWook added the enhancement New feature or request label Nov 21, 2024
@MrWook
Copy link
Collaborator

MrWook commented Nov 21, 2024

hey @ozgursarikamis thanks for the new language pack.
Do you have some sources for those dictionary?

@ozgursarikamis
Copy link
Author

Hello @MrWook , I assume you're asking about online resources. I mostly translated myself. But you can use Google Translate to verify the translations. In addition to that, you can check Kurdish Institution of Paris to have some reference.

https://www.institutkurde.org/publications/kurmanci/dictionnaire/

Let me know if you have any other questions. Thank you.

Copy link
Contributor

@w-masahiro-ct w-masahiro-ct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.
Just a couple of minor suggestions—please take a look🙂

{
"extends": "../../../tsconfig.json"
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The closing bracket is misplaced.
There is redundant whitespace.

"@zxcvbn-ts/dictionary-compression": "^2.0.0"
}
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The closing bracket is misplaced.
There is redundant whitespace.

See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

## Initial release
(2024-11-20)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this:

# Change Log

All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

## 4.0.0-beta.2 (202X-XX-XX)

### Features

- **language:** Add kurdish language pack ([ca6263b](https://github.com/zxcvbn-ts/zxcvbn/pull/289/commits/ca6263ba3131fdc118302e7aeae26e199e7ca7de))

@MrWook
Copy link
Collaborator

MrWook commented Dec 26, 2024

Hey @ozgursarikamis i'm not talking about the translation but rather about the dictionaries like firstname.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants