fix(ui): prevent replace failed node without selecting a node #4380
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Nodes Manager dialog allowed users to proceed with the "replace failed node" workflow without actually selecting a node to replace. This resulted in users being able to click through all the steps (Action → Node Id → Inclusion Mode) without any validation, but no actual replacement would occur in the backend since no node ID was provided.
Problem
In the
DialogNodesManager.vuecomponent, thenextStep()function processed the 'replaceFailed' step without validating whether a node had been selected (replaceIdvalue). This allowed the workflow to proceed to the inclusion mode step even whenreplaceIdwasnullorundefined.Solution
Added proper validation to prevent progression without node selection:
Created
submitReplaceFailed()validation function that:nextStep()after successful validationUpdated the Next button in the replaceFailed step to use
submitReplaceFailed()instead of directly callingnextStep()Added informative error messages:
Before/After
Before: Users could click "NEXT" without selecting a node and proceed through all steps, but nothing would happen in the backend.
After: Users must select a valid node before they can proceed, with clear error messages guiding them when validation fails.
The fix maintains full backward compatibility while ensuring the replace failed node workflow requires proper node selection.
Fixes #4379.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
224.0.0.251If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.