-
-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(config): correct Fibaro FGMS001 config to conform to Fibaro official #7463
Open
xyanide
wants to merge
3
commits into
zwave-js:master
Choose a base branch
from
xyanide:patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://manuals.fibaro.com/motion-sensor/ Group information: 1st Association Group – “Lifeline” reports the device status and allows for assigning single device only (main controller by default). 2nd Association Group – “Motion” is assigned to the motion sensor – sends motion detection and alarm cancellation frames to the associated devices. 3rd Association Group – “Tamper” is assigned to the tamper – sends tamper alarm and alarm cancellation frames to the associated devices. 4th Association Group – “Motion BC” is assigned to the motion sensor – sends motion detection and alarm cancellation frames to the associated devices. Provides backward compatibility with controllers not supporting Z-Wave+ protocol. 5th Association Group – “Tamper BC” is assigned to the tamper – sends tamper alarm and alarm cancellation frames to the associated devices. Provides backward compatibility with controllers not supporting Z-Wave+ protocol.
xyanide
changed the title
Update fgms001.json to conform to Fibaro official documentation
feat(config): Update fgms001.json to conform to Fibaro official documentation
Dec 7, 2024
xyanide
changed the title
feat(config): Update fgms001.json to conform to Fibaro official documentation
fix(config): Update fgms001.json to conform to Fibaro official documentation
Dec 7, 2024
xyanide
changed the title
fix(config): Update fgms001.json to conform to Fibaro official documentation
fix(config): Update fgms001 doc to conform to Fibaro official
Dec 7, 2024
xyanide
changed the title
fix(config): Update fgms001 doc to conform to Fibaro official
fix(config): Update Fibaro fgms001 doc to conform to Fibaro official
Dec 7, 2024
xyanide
changed the title
fix(config): Update Fibaro fgms001 doc to conform to Fibaro official
fix(config): update Fibaro fgms001 doc to conform to Fibaro official
Dec 7, 2024
xyanide
changed the title
fix(config): update Fibaro fgms001 doc to conform to Fibaro official
fix(config): correct Fibaro FGMS001 config to conform to Fibaro official
Dec 7, 2024
manutremo
approved these changes
Dec 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been having lots of problems with this incorrect file, but the changes to the definitions of the groups seems correct now. Please someone with the correct permissions provide an approving review so it can be merged. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a lot of trouble with setting up associations with my FGMS001 motion sensor from Fibaro.
Turns out the configuration in the documentation was incorrect. After reviewing the documentation at https://manuals.fibaro.com/motion-sensor/ I came to the conclusion ZwaveJS was reporting the associations groups incorrectly.
ZwaveJS documentation link: https://devices.zwave-js.io/?jumpTo=0x010f:0x0800:0x1001:0.0#
This PR corrects the association group names and limits.
Group information:
1st Association Group – “Lifeline” reports the device status and allows for assigning single device only (main controller by default).
2nd Association Group – “Motion” is assigned to the motion sensor – sends motion detection and alarm cancellation frames to the associated devices.
3rd Association Group – “Tamper” is assigned to the tamper – sends tamper alarm and alarm cancellation frames to the associated devices.
4th Association Group – “Motion BC” is assigned to the motion sensor – sends motion detection and alarm cancellation frames to the associated devices. Provides backward compatibility with controllers not supporting Z-Wave+ protocol.
5th Association Group – “Tamper BC” is assigned to the tamper – sends tamper alarm and alarm cancellation frames to the associated devices. Provides backward compatibility with controllers not supporting Z-Wave+ protocol.