Skip to content

Commit

Permalink
chore(over window): make some logs trace level (risingwavelabs#12559)
Browse files Browse the repository at this point in the history
Signed-off-by: Richard Chien <[email protected]>
  • Loading branch information
stdrc authored Sep 27, 2023
1 parent ea803de commit e7024f5
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions src/stream/src/executor/over_window/over_partition.rs
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ pub(super) fn shrink_partition_cache(
cache_policy: CachePolicy,
recently_accessed_range: RangeInclusive<StateKey>,
) {
tracing::debug!(
tracing::trace!(
this_partition_key=?this_partition_key,
cache_policy=?cache_policy,
recently_accessed_range=?recently_accessed_range,
Expand Down Expand Up @@ -199,7 +199,7 @@ pub(super) fn shrink_partition_cache(
}
};

tracing::debug!(
tracing::trace!(
this_partition_key=?this_partition_key,
retain_range=?(&start..=&end),
"retain range in the range cache"
Expand Down Expand Up @@ -431,16 +431,16 @@ impl<'a, S: StateStore> OverPartition<'a, S> {

if left_reached_sentinel {
// TODO(rc): should count cache miss for this, and also the below
tracing::debug!(partition=?self.this_partition_key, "partition cache left extension triggered");
tracing::trace!(partition=?self.this_partition_key, "partition cache left extension triggered");
let left_most = self.cache_real_first_key().unwrap_or(delta_first).clone();
self.extend_cache_leftward_by_n(table, &left_most).await?;
}
if right_reached_sentinel {
tracing::debug!(partition=?self.this_partition_key, "partition cache right extension triggered");
tracing::trace!(partition=?self.this_partition_key, "partition cache right extension triggered");
let right_most = self.cache_real_last_key().unwrap_or(delta_last).clone();
self.extend_cache_rightward_by_n(table, &right_most).await?;
}
tracing::debug!(partition=?self.this_partition_key, "partition cache extended");
tracing::trace!(partition=?self.this_partition_key, "partition cache extended");
}
}

Expand All @@ -453,7 +453,7 @@ impl<'a, S: StateStore> OverPartition<'a, S> {
return Ok(());
}

tracing::debug!(partition=?self.this_partition_key, "loading the whole partition into cache");
tracing::trace!(partition=?self.this_partition_key, "loading the whole partition into cache");

let mut new_cache = PartitionCache::new(); // shouldn't use `new_empty_partition_cache` here because we don't want sentinels
let table_iter = table
Expand Down Expand Up @@ -530,7 +530,7 @@ impl<'a, S: StateStore> OverPartition<'a, S> {
Bound::Included(self.state_key_to_table_pk(range.start())?),
Bound::Excluded(self.state_key_to_table_pk(cache_real_first_key)?),
);
tracing::debug!(
tracing::trace!(
partition=?self.this_partition_key,
table_pk_range=?table_pk_range,
"loading the left half of given range"
Expand All @@ -546,7 +546,7 @@ impl<'a, S: StateStore> OverPartition<'a, S> {
Bound::Excluded(self.state_key_to_table_pk(cache_real_last_key)?),
Bound::Included(self.state_key_to_table_pk(range.end())?),
);
tracing::debug!(
tracing::trace!(
partition=?self.this_partition_key,
table_pk_range=?table_pk_range,
"loading the right half of given range"
Expand Down

0 comments on commit e7024f5

Please sign in to comment.