Skip to content

Conversation

sahith-ch
Copy link
Collaborator

@sahith-ch sahith-ch commented Mar 23, 2025

What does this PR do, and why?

This PR integrates the recent conversations feature into Zulip-Terminal, allowing users to quickly access their latest chats. This improves usability by reducing navigation time and making it easier to switch between discussions.

External discussion & connections

  • Discussed in #zulip-terminal in topic
  • [x ] Fully fixes Add Recent Conversations Feature #1565
  • Partially fixes issue #
  • Builds upon previous unmerged work in PR #
  • Is a follow-up to work in PR #
  • Requires merge of PR #
  • Merge will enable work on #

How did you test this?

  • Manually - Behavioral changes
  • [ x] Manually - Visual changes
  • Adapting existing automated tests
  • Adding automated tests for new behavior (or missing tests)
  • Existing automated tests should already cover this (only a refactor of tested code)

Visual changes

image

@zulipbot zulipbot added size: XL [Automatic label added by zulipbot] missing feature A general missing feature, present in another Zulip client labels Mar 23, 2025
Implemented a new RecentConversationsView in ui_tools/views.py to display
recent conversation data fetched via model.py. Updated core.py and ui.py to
integrate this view into the main application flow. Modified cli/run.py to
support initialization of conversation data, and adjusted keys.py and
ui_sizes.py for navigation and layout consistency. Added button support in
ui_tools/buttons.py for interacting with conversations.

This enhances zulip-terminal’s interactivity by allowing users to view and
navigate recent conversations, addressing requirements from issue zulip#1565.

Fixes zulip#1565.
@amanagr
Copy link
Member

amanagr commented Mar 24, 2025

Can you remove the non relevant changes from the PR?

Also, does this support keyboard navigation?

@sahith-ch
Copy link
Collaborator Author

Yeh sure I will remove non relevant changes and
It does support keyboard navigation

@neiljp
Copy link
Collaborator

neiljp commented Mar 31, 2025

@sahith-ch I left feedback in the channel, since it may be easier to discuss there, and there's a lot of background discussion that I'm not sure if you've read?

@neiljp neiljp added the PR awaiting update PR has been reviewed & is awaiting update or response to reviewer feedback label Mar 31, 2025
sahith-ch and others added 7 commits April 12, 2025 19:55
Implemented a new RecentConversationsView in ui_tools/views.py to display
recent conversation data fetched via model.py. Updated core.py and ui.py to
integrate this view into the main application flow. Modified cli/run.py to
support initialization of conversation data, and adjusted keys.py and
ui_sizes.py for navigation and layout consistency. Added button support in
ui_tools/buttons.py for interacting with conversations.

This enhances zulip-terminal’s interactivity by allowing users to view and
navigate recent conversations, addressing requirements from issue zulip#1565.

Fixes zulip#1565.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
missing feature A general missing feature, present in another Zulip client PR awaiting update PR has been reviewed & is awaiting update or response to reviewer feedback size: XL [Automatic label added by zulipbot]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Recent Conversations Feature
4 participants