tools/bump-version: Update for current version numbers; refactor; handle mismatch #1874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is NFC except in its handling of errors. I haven't been using this script since the app launched (and have instead done its work manually), because it assumes the version numbers are 0.0.N+N. After this commit, it's a small local change to make the script handle the new 30.0.N+N version numbers, and the script will also fail cleanly if we ever change the format again.
In principle it wouldn't be hard to generalize this logic further, reading out the current major and minor version numbers rather than expecting them to have certain values. But it's not obvious what direction we'd want such generalization to go in -- that depends on what our version-numbering practices would be after they change. On current plans, the versions will be 30.0.N+N indefinitely, so it's inherently uncertain what pattern we might choose (and therefore how the version should get bumped by this script) after we change those plans, if we someday do. So just leave the generalization to be done if and when we need it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested this script manually, and with this change it's back to working for me.
Commit messages
913621b tools/bump-version: Better centralize version format; handle mismatch
This is NFC except in its handling of errors.
I haven't been using this script since the app launched (and have
instead done its work manually), because it assumes the version
numbers are 0.0.N+N. After this commit, it's a small local change to
make the script handle the new 30.0.N+N version numbers, and the
script will also fail cleanly if we ever change the format again.
d884078 tools/bump-version: Update for current version numbers
In principle it wouldn't be hard to generalize this logic further,
reading out the current major and minor version numbers rather than
expecting them to have certain values.
But it's not obvious what direction we'd want such generalization
to go in -- that depends on what our version-numbering practices
would be after they change. On current plans, the versions will be
30.0.N+N indefinitely, so it's inherently uncertain what pattern we
might choose (and therefore how the version should get bumped by
this script) after we change those plans, if we someday do.
So just leave the generalization to be done if and when we need it.