push_device: Move registering push token off of UpdateMachine; fix ad-hoc Future used for tests #1866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This logic is about the token, and this is the class that tracks the token in the first place, so the logic might as well live here on this class.
This makes a more comfortable home for adding further logic in this area.
Now these tests invoke this code the same way it gets invoked in production. Instead of directly invoking a registerToken method, they use a debug hook that can only pause and resume a control path which has already been started.
|
Thanks, LGTM! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor helps prepare for #1764, the new E2EE notifications.
As a bonus, it also cleans up what had been a messy area of UpdateMachine.