Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language setting #1461

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

AshutoshKhadse23
Copy link

Issue #1139

Added the language setting into the appropriate setting button.

issue.1139.mp4

@gnprice
Copy link
Member

gnprice commented Apr 3, 2025

Hi, thanks for the contribution.

Please see our README for the basic requirements this PR will need to meet before we can review it.

@AshutoshKhadse23
Copy link
Author

Did you mean to add test for the language code ?

@gnprice
Copy link
Member

gnprice commented Apr 3, 2025

What does the README say under "Submitting a pull request"?

@AshutoshKhadse23
Copy link
Author

Understood !!

@AshutoshKhadse23
Copy link
Author

Added the test which ensure that :

  • Users can view and change language settings
  • The UI properly reflects the current language
  • Navigation works correctly
  • The search functionality is present
  • Selection state is visually indicated

@gnprice
Copy link
Member

gnprice commented Apr 3, 2025

Yeah, tests are one thing that's needed. There are two bulleted list items in that section, though — what's the other one say?

This also doesn't appear to actually add any setting. A setting means something the user sets which is then stored, on the device, so that their choice is remembered the next time they run the app. See the issue, and the broader issue it links to which this issue is "an instance of".

@AshutoshKhadse23
Copy link
Author

Sorry for that I will add the relevant test case for that and now I had store the language preference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants