-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add language setting #1461
base: main
Are you sure you want to change the base?
Add language setting #1461
Conversation
Update translations from Weblate
Hi, thanks for the contribution. Please see our README for the basic requirements this PR will need to meet before we can review it. |
Did you mean to add test for the language code ? |
What does the README say under "Submitting a pull request"? |
Understood !! |
Added the test which ensure that :
|
Yeah, tests are one thing that's needed. There are two bulleted list items in that section, though — what's the other one say? This also doesn't appear to actually add any setting. A setting means something the user sets which is then stored, on the device, so that their choice is remembered the next time they run the app. See the issue, and the broader issue it links to which this issue is "an instance of". |
…anguage-setting # Conflicts: # test/widgets/settings_test.dart
Sorry for that I will add the relevant test case for that and now I had store the language preference. |
Issue #1139
Added the language setting into the appropriate setting button.
issue.1139.mp4