Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented pronouns in @-mentions autocomplete #1434

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Parth-11
Copy link

Description:

This PR adds pronouns to @-mentions autocomplete and is a solution to issue #313. Below attached image shows the implementation of the same

image

@PIG208
Copy link
Member

PIG208 commented Mar 24, 2025

Hi @Parth-11, welcome. This issue has the M6 Post-launch milestone, which means the core team isn't going to be able to spend time in the next couple of months to review or help with work on it. If you'd like to contribute to Zulip, see the guide in our README and the resources linked from there:
https://github.com/zulip/zulip-flutter#picking-an-issue-to-work-on

@gnprice gnprice added this to the M6: Post-launch milestone Mar 24, 2025
@gnprice gnprice marked this pull request as draft March 24, 2025 20:14
@gnprice
Copy link
Member

gnprice commented Mar 31, 2025

Separately from being for a post-launch issue, from a quick look I see that this PR doesn't meet the two requirements for us to be able to review a PR in general: it doesn't have tests, and it's not composed of clear and coherent commits. These are described in our README:
https://github.com/zulip/zulip-flutter#submitting-a-pull-request

So if you decide to pick up a launch issue and you send a PR for that, please spend some time to make sure your new PR meets those requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants