Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: Fix weblate action's rights, and update generated code. #1262

Merged
merged 3 commits into from
Feb 28, 2025

Conversation

alexmv
Copy link
Contributor

@alexmv alexmv commented Jan 8, 2025

This replaces #1192, with the branch pushed to zulip/zulip-flutter so that it can possibly be tested before merging.

@alexmv alexmv force-pushed the action-rights-generated branch 11 times, most recently from 6264d21 to 7dff110 Compare January 13, 2025 20:51
Copy link
Member

@PIG208 PIG208 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, the PR created for testing is #1279. I just triggered another run and that PR got updated.

@alexmv alexmv force-pushed the action-rights-generated branch from 7dff110 to bf74d0d Compare February 26, 2025 19:04
@alexmv
Copy link
Contributor Author

alexmv commented Feb 26, 2025

Repushed, with comments addressed and the DO NOT MERGE trailing commit stripped off.

@PIG208
Copy link
Member

PIG208 commented Feb 27, 2025

Just manually triggered a run. Let's see how it does.

@alexmv
Copy link
Contributor Author

alexmv commented Feb 27, 2025

The runs won't work because I stripped off the final commit which makes this work on non-main.

@gnprice
Copy link
Member

gnprice commented Feb 28, 2025

Thanks! This looks good; merging, and then I'll try a run from main.

@gnprice gnprice force-pushed the action-rights-generated branch from bf74d0d to 6bbe74f Compare February 28, 2025 01:37
@gnprice gnprice merged commit 6bbe74f into main Feb 28, 2025
2 checks passed
@gnprice gnprice deleted the action-rights-generated branch February 28, 2025 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants