Skip to content

Simplify topic action sheet slightly #1182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

gnprice
Copy link
Member

@gnprice gnprice commented Dec 19, 2024

These are some small NFC followups on #1041, which I sketched last week while reviewing it but left aside while we were finishing last week's beta.

@gnprice gnprice added the maintainer review PR ready for review by Zulip maintainers label Dec 19, 2024
@gnprice gnprice requested a review from PIG208 December 19, 2024 21:55
Copy link
Member

@PIG208 PIG208 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This LGTM.

@gnprice gnprice force-pushed the pr-topic-actions-nfc branch from a11fdad to cf26d30 Compare December 19, 2024 23:46
@PIG208 PIG208 closed this Jan 2, 2025
@PIG208 PIG208 force-pushed the pr-topic-actions-nfc branch from cf26d30 to 6070a7f Compare January 2, 2025 02:37
@PIG208
Copy link
Member

PIG208 commented Jan 2, 2025

Just merged this (6070a7f). Pushed in the wrong order that it closes the PR, whoops.

@gnprice
Copy link
Member Author

gnprice commented Jan 7, 2025

Thanks!

Pushed in the wrong order that it closes the PR, whoops.

FTR, the very handy tool I use for this is tools/push-to-pull-request in the zulip/zulip repo. So e.g. the command I ran a couple of minutes ago to merge #1092 was:

$ ~/z/zulip/tools/push-to-pull-request --merge 1092

There's always a version of that command in my shell history (because I use it all the time); so I search history with Ctrl+R, "ls/p" (which is a specific enough query to find it basically every time), then edit the command and hit Enter.

Instead of using shell history, your style might be to make an alias for it instead; that'd work well too.

@gnprice gnprice deleted the pr-topic-actions-nfc branch January 7, 2025 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer review PR ready for review by Zulip maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants