Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposing Whitelisted Protocols to User Settings #1298

Closed
wants to merge 105 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
105 commits
Select commit Hold shift + click to select a range
e810cec
adding link utils for custom protocolLauncher
jonassorgenfrei Apr 4, 2023
f3876a1
Merge branch 'zulip:main' into main
jonassorgenfrei Apr 5, 2023
d198a8d
replacing object schema by map schema
jonassorgenfrei Apr 5, 2023
93b6b39
Merge branch 'main' of github.com:jonassorgenfrei/zulip-desktop
jonassorgenfrei Apr 5, 2023
521dddb
cleaned up code style
jonassorgenfrei Apr 5, 2023
0af82b4
cleanup up import structure
jonassorgenfrei Apr 5, 2023
377f708
fix import order
jonassorgenfrei Apr 5, 2023
122533a
added whitelistProtocols to config
jonassorgenfrei Apr 6, 2023
8337106
Merge branch 'zulip:main' into main
jonassorgenfrei Apr 19, 2023
e8e8e5c
Merge branch 'zulip:main' into main
jonassorgenfrei Apr 28, 2023
acde121
Merge branch 'zulip:main' into main
jonassorgenfrei May 7, 2023
1b6c0fc
Merge branch 'zulip:main' into main
jonassorgenfrei Dec 27, 2024
f25b7e7
added tel and sip to default protocols
jonassorgenfrei Dec 27, 2024
0256e8e
preference: Fix spellchecker languages dropdown positioning.
andersk Apr 4, 2023
1cdda21
cleaned up code style
jonassorgenfrei Apr 5, 2023
f7cfcb6
cleanup up import structure
jonassorgenfrei Apr 5, 2023
2128169
fix import order
jonassorgenfrei Apr 5, 2023
c9769a5
added whitelistProtocols to config
jonassorgenfrei Apr 6, 2023
13a55ac
Handle exceptions when reading server icons.
andersk Apr 18, 2023
66e9bbf
Don’t show visual notifications when they’re turned off.
andersk Apr 18, 2023
dd2bec3
xo: Remove redundant exclusion of unicorn/prefer-json-parse-buffer.
andersk Apr 18, 2023
58e7e39
preference: Fix CSS in Vite dev mode.
andersk Apr 18, 2023
a3d0f1c
Fix typos.
andersk Apr 19, 2023
12a7c4d
Fix handling of server icon updates and errors.
andersk Apr 21, 2023
4a1dc74
server-tab: Encapsulate setName and setIcon.
andersk May 3, 2023
643cca3
Fix updating of server names and icons at startup.
andersk May 4, 2023
bdda175
Fix more typos.
andersk May 5, 2023
1f7786c
translation-util: Expose the full functionality of __.
andersk May 5, 2023
1726855
translations: Update en.json.
andersk May 5, 2023
ca136ee
tx: Migrate configuration to current Transifex CLI.
andersk May 5, 2023
cdf8347
translations: Update translations from Transifex.
andersk May 5, 2023
af1ee67
webview: Add destroy method.
andersk Apr 5, 2023
53e7bd6
webview: Use private members.
andersk Apr 5, 2023
44c5ed7
webview: Use private methods.
andersk Apr 5, 2023
b17a080
webview: Add a wrapper pane around the real <webview>.
andersk Apr 5, 2023
c1d5d88
Display a banner for unsupported Zulip Server versions.
andersk Apr 5, 2023
6403293
preload: Drop compatibility injected JS for Zulip Server < 3.0.
andersk Apr 13, 2022
db7f0f6
preload: Drop compatibility code for Zulip Server < 4.0.
andersk May 4, 2023
f3e8b22
preference: Fix server icon display in connected organizations list.
andersk May 5, 2023
f38f757
translations: Update en.json.
andersk May 5, 2023
2597465
translations: Update translations from Transifex.
andersk May 5, 2023
97ad50c
stylelint: Fix media-feature-range-notation.
andersk Apr 4, 2023
fab210c
stylelint: Fix declaration-block-no-redundant-longhand-properties.
andersk Apr 4, 2023
806483a
Upgrade dependencies, including Electron 24.2.0.
andersk May 5, 2023
677eb46
release: New release v5.10.0.
andersk May 5, 2023
5c4c8da
renderer: Improve GIF loading spinner with new SVG.
Jan 9, 2023
c064cb5
renderer: Remove unused reloadView argument.
andersk Sep 14, 2023
c6b8b60
Use Electron Event type.
andersk Sep 14, 2023
a3c3863
renderer: Compensate for Chrome’s removal of overflow: overlay.
andersk Sep 14, 2023
085a04f
Upgrade xo and prettier.
andersk Sep 14, 2023
be09f2a
Upgrade dependencies, including Electron 26.2.1.
andersk Sep 14, 2023
a90778b
translations: Update translations from Transifex.
andersk Sep 14, 2023
866b245
Use electron fetch API.
andersk Sep 14, 2023
15f0c87
workflows: Update actions/checkout to v4.
andersk Sep 14, 2023
079df0e
release: New release v5.10.1.
andersk Sep 14, 2023
cbbc90d
Downgrade Electron from 26.2.1 to 25.8.1 to avoid renderer crash.
andersk Sep 14, 2023
bb4f6cf
release: New release v5.10.2.
andersk Sep 14, 2023
862979d
Fix gatemaker TypeError with Electron 25.
andersk Sep 30, 2023
a8714ef
Upgrade dependencies, including Electron 25.8.4.
andersk Sep 30, 2023
ce13b44
release: New release v5.10.3.
andersk Sep 30, 2023
ce1e2a9
Avoid deprecated ipcRenderer.sendTo.
andersk Jan 9, 2024
21b0f28
Upgrade dependencies, including Electron 28.1.1.
andersk Jan 9, 2024
d038732
electron-bridge: Fix unicorn/prefer-node-protocol.
andersk Jan 9, 2024
4887755
release: New release v5.10.4.
andersk Jan 9, 2024
4e69f97
Use process-specific @sentry/electron modules.
andersk Jan 22, 2024
6935836
Use process-specific electron-log modules.
andersk Jan 22, 2024
2ae4af2
autoupdater: Use a separate electron-log instance.
andersk Jan 22, 2024
fd7c1ac
Upgrade dependencies, including Electron 28.2.0.
andersk Jan 25, 2024
953fda5
Set a restrictive Content-Security-Policy for the app UI.
andersk Jan 25, 2024
f95a566
release: New release v5.10.5.
andersk Jan 26, 2024
fba4db5
webview: Use an exponential scale for zooming.
andersk Mar 21, 2024
e66d471
webview: Enable zooming with the mouse wheel.
andersk Mar 21, 2024
632c5e5
Allow hiding the window from full screen mode on macOS.
Jan 27, 2024
8cf43ec
Remove dialog for certificate errors on subresources.
andersk Mar 22, 2024
42d0338
xo: Fix import/no-duplicates.
andersk Mar 22, 2024
904b45b
xo: Fix unicorn/prevent-abbreviations.
andersk Mar 22, 2024
363f40f
Upgrade dependencies, including Electron 29.1.5.
andersk Mar 22, 2024
2fc4c7f
release: New release v5.11.0.
andersk Mar 22, 2024
306e4b9
ci: Replace Travis CI badge with GitHub Actions.
mbrukman Jul 2, 2024
c83bccb
Remove rimraf.
andersk Aug 7, 2024
7b7e151
stylelint: Fix declaration-block-no-shorthand-property-overrides.
andersk Aug 7, 2024
66b6f9f
tsconfig: Work around @sentry/electron regression.
andersk Aug 7, 2024
ed7110d
preference: Show spellchecker language names from Intl.DisplayNames.
andersk Aug 22, 2024
6e86511
preference: Sort spellchecker language names with localeCompare.
andersk Aug 22, 2024
40181a7
translations: Sort supported-locales by display name.
andersk Aug 22, 2024
472ad58
translations: Update translations from Transifex.
andersk Aug 22, 2024
41fc4c6
Upgrade dependencies, including Electron 32.0.1.
andersk Aug 22, 2024
7b59ef5
xo: Remove obsolete scripts/notarize.js options.
andersk Aug 22, 2024
f8c0715
Sign Windows binaries with Azure Trusted Signing.
andersk Aug 23, 2024
2c2a75f
release: New release v5.11.1.
andersk Aug 23, 2024
c609e40
nav: Statically mark navigation items for translation.
andersk Dec 2, 2024
db4fd03
translations: Add missing translatable strings with i18next-scanner.
andersk Dec 2, 2024
854c7bd
functional-tab: Split ‘name’ into ‘page’ and ‘label’.
andersk Dec 2, 2024
e107367
renderer: Mark strings for translation.
andersk Dec 2, 2024
fb5ca5c
about: Mark strings for translation.
andersk Dec 2, 2024
2a41736
about: Remove inexplicable ‘cursor: pointer’.
andersk Dec 2, 2024
830aecc
Mark dialog strings for translation.
andersk Dec 2, 2024
d301d39
translations: Remove empty el_GR duplicate translation.
alexmv Dec 11, 2024
355855b
translations: Remove zh-Hant translation.
alexmv Dec 11, 2024
e11a591
translations: Remove control characters from zh_TW translation string.
alexmv Dec 11, 2024
d40d084
preference: Rename show app unread badge setting.
shubham-padia Dec 11, 2024
4235ca1
github: Use zulip/zulip pull request template style.
timabbott Nov 25, 2024
db782a4
supported-locales: Fix for removal of el_GR and zh-Hant.
andersk Dec 11, 2024
f4dc8b4
added tel and sip to default protocols
jonassorgenfrei Dec 27, 2024
cd2d07f
Merge branch 'main' of github.com:jonassorgenfrei/zulip-desktop into …
jonassorgenfrei Dec 27, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/common/config-schemata.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ export const configSchemata = {
lastActiveTab: z.number(),
promptDownload: z.boolean(),
proxyBypass: z.string(),
whitelistedProtocols: z.string().array(),
// eslint-disable-next-line @typescript-eslint/naming-convention
proxyPAC: z.string(),
proxyRules: z.string(),
Expand Down
12 changes: 11 additions & 1 deletion app/common/link-util.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,20 @@ import fs from "node:fs";
import os from "node:os";
import path from "node:path";

import * as ConfigUtil from "./config-util.js";
import {html} from "./html.js";

/* Fetches the current protocolLaunchers from settings.json */
const whitelistedProtocols = ConfigUtil.getConfigItem("whitelistedProtocols", [
"http:",
"https:",
"mailto:",
"tel:",
"sip:",
]);

export async function openBrowser(url: URL): Promise<void> {
if (["http:", "https:", "mailto:"].includes(url.protocol)) {
if (whitelistedProtocols.includes(url.protocol)) {
await shell.openExternal(url.href);
} else {
// For security, indirect links to non-whitelisted protocols
Expand Down
Loading