Turn tsconfig settings to 11 (angular-redux#438)

Adding `"noUnusedLocals": true, "noUnusedParameters": true` caught a bunch of minor stuff.

src/components/root-store.spec.ts

@@ -9,8 +9,6 @@ import { NgRedux } from './ng-redux';
 import { RootStore } from './root-store';
 import { select } from '../decorators/select';
 
-const returnPojo = () => ({});
-
 class MockNgZone {
   run = (fn: Function) => fn()
 }
@@ -122,7 +120,7 @@ describe('NgRedux Observable Store', () => {
     const spy = jasmine
       .createSpy('spy')
       .and.callFake((foo: string) => { fooData = foo; });
-    const foo$ = ngRedux
+    ngRedux
       .select(state => `${state.foo}-${state.baz}`)
       .subscribe(spy);
 
@@ -153,7 +151,7 @@ describe('NgRedux Observable Store', () => {
       .and.callFake((data: IRecord) => fooData = data);
     const cmp = (a: IRecord, b: IRecord) => a.data === b.data;
 
-    const foo$ = ngRedux
+    ngRedux
       .select(state => ({ data: `${state.foo}-${state.baz}` }), cmp)
       .subscribe(spy);
 
@@ -203,7 +201,7 @@ describe('NgRedux Observable Store', () => {
       bar: string;
       baz: number;
 
-      constructor(private _ngRedux: NgRedux<any>) {
+      constructor(_ngRedux: NgRedux<any>) {
         _ngRedux.select(n => n.foo).subscribe(foo => this.foo = foo);
         _ngRedux.select(n => n.bar).subscribe(bar => this.bar = bar);
         _ngRedux.select(n => n.baz).subscribe(baz => this.baz = baz);

src/components/sub-store.spec.ts

@@ -1,5 +1,4 @@
 import { NgZone } from '@angular/core';
-import { async } from '@angular/core/testing'
 import { Action } from 'redux';
 import { RootStore } from './root-store';
 import { NgRedux } from './ng-redux';
@@ -22,7 +21,7 @@ interface IAppState {
 }
 
 describe('Substore', () => {
-  const defaultReducer = (state: any, action: Action) => state;
+  const defaultReducer = (state: any, _: Action) => state;
 
   const basePath = ['foo', 'bar'];
   let ngRedux: NgRedux<IAppState>;

src/components/sub-store.ts

@@ -1,15 +1,12 @@
-import { Dispatch, Reducer, Action } from 'redux';
+import { Dispatch, Reducer } from 'redux';
 import { Observable } from 'rxjs/Observable';
 import 'rxjs/add/operator/map';
 import 'rxjs/add/operator/distinctUntilChanged';
 
 import { getIn } from '../utils/get-in';
-import { setIn } from '../utils/set-in';
 import {
   PathSelector,
   Selector,
-  PropertySelector,
-  FunctionSelector,
   Comparator,
   resolveToFunctionSelector,
 } from './selectors';

src/decorators/dispatch.spec.ts

@@ -132,7 +132,7 @@ describe('@dispatch', () => {
   });
 
   describe('On a substore', () => {
-    const localReducer = (state: any, action: Action) => state;
+    const localReducer = (state: any, _: Action) => state;
     @WithSubStore({
       basePathMethodName: 'getBasePath',
       localReducer,

src/decorators/select.spec.ts

@@ -98,7 +98,7 @@ describe('Select decorators', () => {
     });
 
     describe('when passed a comparator', () => {
-      const comparator = (x: any, y: any): boolean => y === 1;
+      const comparator = (_: any, y: any): boolean => y === 1;
       class MockClass { @select('baz', comparator) baz$: Observable<number> };
 
       it('should only trigger next when comparator returns true', done => {
@@ -151,7 +151,7 @@ describe('Select decorators', () => {
     });
 
     describe('when passed a comparator', () => {
-      const comparator = (x: any, y: any): boolean => y === 1;
+      const comparator = (_: any, y: any): boolean => y === 1;
       class MockClass { @select$('baz', transformer, comparator) baz$: Observable<number> }
 
       it('should only trigger next when the comparator returns true', done => {

src/decorators/select.ts

@@ -1,10 +1,6 @@
-import { Observable } from 'rxjs/Observable';
-import { ReplaySubject } from 'rxjs/ReplaySubject';
 import 'rxjs/add/operator/let'
-import { NgRedux } from '../components/ng-redux';
-import { ObservableStore } from '../components/observable-store';
 import { Selector, Comparator, Transformer } from '../components/selectors';
-import { IFractalStoreOptions, getInstanceSelection } from './helpers';
+import { getInstanceSelection } from './helpers';
 
 /**
  * Selects an observable from the store, and attaches it to the decorated

src/decorators/with-sub-store.spec.ts

@@ -16,7 +16,7 @@ class MockNgZone { run = (fn: Function) => fn() }
 
 describe('@WithSubStore', () => {
   let ngRedux: NgRedux<any>;
-  const localReducer = (state: any, action: Action) => state;
+  const localReducer = (state: any, _: Action) => state;
   const basePathMethodName = 'getSubStorePath';
 
   beforeEach(() => {
@@ -30,7 +30,7 @@ describe('@WithSubStore', () => {
     ngRedux = new RootStore(new MockNgZone() as NgZone);
     NgRedux.instance = ngRedux;
     ngRedux.configureStore(
-      (state: any, action: Action) => state,
+      (state: any, _: Action) => state,
       defaultState);
   });
 

src/decorators/with-sub-store.ts

@@ -1,4 +1,3 @@
-import { Reducer } from 'redux';
 import { IFractalStoreOptions, setClassOptions } from './helpers';
 
 /**

testing/ng-redux.mock.spec.ts

@@ -1,4 +1,4 @@
-import { TestBed, async } from '@angular/core/testing';
+import { TestBed } from '@angular/core/testing';
 import { Component } from '@angular/core';
 import { Observable } from 'rxjs';
 import 'rxjs/add/operator/toArray';

testing/ng-redux.mock.ts

@@ -2,13 +2,11 @@ import {
   NgRedux,
   Selector,
   Comparator,
-  ObservableStore,
   PathSelector,
 } from '@angular-redux/store';
-import { Reducer, Action, Dispatch, Middleware, Store, StoreEnhancer } from 'redux';
+import { Reducer, Dispatch, Middleware, Store, StoreEnhancer } from 'redux';
 import { Observable } from 'rxjs/Observable';
 import { Subject } from 'rxjs/Subject';
-import { ReplaySubject } from 'rxjs/ReplaySubject';
 import 'rxjs/add/observable/from';
 import 'rxjs/add/operator/distinctUntilChanged';
 import { MockObservableStore } from './observable-store.mock';
@@ -71,16 +69,18 @@ export class MockNgRedux extends NgRedux<any> {
     return MockNgRedux.mockInstance;
   }
 
-  provideStore = (store: Store<any>): void  => {};
+  provideStore = (_: Store<any>): void  => {};
   configureStore = (
-    rootReducer: Reducer<any>,
-    initState: any,
-    middleware?: Middleware[],
-    enhancers?: StoreEnhancer<any>[]): void => {};
+    _: Reducer<any>,
+    __: any,
+    ___?: Middleware[],
+    ____?: StoreEnhancer<any>[]): void => {};
 
   configureSubStore = this.mockRootStore.configureSubStore;
-  select = this.mockRootStore.select;
-
+  select: <SelectedType>(
+    selector: Selector<any, SelectedType>,
+    comparator?: Comparator) => Observable<SelectedType> = this.mockRootStore.select;
+
   dispatch = this.mockRootStore.dispatch as Dispatch<any>;
   getState = this.mockRootStore.getState;
   subscribe = this.mockRootStore.subscribe;

testing/observable-store.mock.ts

@@ -1,13 +1,12 @@
 import {
-  NgRedux,
   Selector,
   Comparator,
   ObservableStore,
   PathSelector,
 } from '@angular-redux/store';
 import { Observable } from 'rxjs/Observable';
 import { Subject } from 'rxjs/Subject';
-import { Reducer, Action, Dispatch } from 'redux';
+import { Reducer, Dispatch } from 'redux';
 import { ReplaySubject } from 'rxjs/ReplaySubject';
 import 'rxjs/add/observable/from';
 import 'rxjs/add/operator/distinctUntilChanged';
@@ -60,7 +59,7 @@ export class MockObservableStore<State> implements ObservableStore<any> {
 
   configureSubStore = <SubState>(
     basePath: PathSelector,
-    localReducer: Reducer<SubState>): MockObservableStore<SubState> =>
+    _: Reducer<SubState>): MockObservableStore<SubState> =>
       this.initSubStore<SubState>(basePath)
 
   getSubStore = <SubState>(...pathSelectors: PathSelector[]): MockObservableStore<any> => {

tsconfig.build.json

@@ -19,7 +19,11 @@
     "paths": {
       "@angular-redux/store": [ "./src/index.ts" ]
     },
-    "skipLibCheck": true
+    "skipLibCheck": true,
+    "forceConsistentCasingInFileNames": true,
+    "noUnusedLocals": true,
+    "noUnusedParameters": true,
+    "pretty": true
   },
   "compileOnSave": false,
   "buildOnSave": false,

tsconfig.docs.json

@@ -15,7 +15,11 @@
       "@angular-redux/store": ["src/index.ts"]
     },
     "strict": true,
-    "skipLibCheck": true
+    "skipLibCheck": true,
+    "forceConsistentCasingInFileNames": true,
+    "noUnusedLocals": true,
+    "noUnusedParameters": true,
+    "pretty": true
   },
   "compileOnSave": false,
   "buildOnSave": false,

tsconfig.json

@@ -19,12 +19,17 @@
       "@angular-redux/store": ["src/index.ts"]
     },
     "strict": true,
-    "skipLibCheck": true
+    "skipLibCheck": true,
+    "forceConsistentCasingInFileNames": true,
+    "noUnusedLocals": true,
+    "noUnusedParameters": true,
+    "pretty": true
   },
   "compileOnSave": false,
   "buildOnSave": false,
   "include": [
-    "src/**/*.ts"
+    "src/**/*.ts",
+    "testing/**/*.ts"
   ],
   "exclude": [
     "node_modules",

tsconfig.testing.json

@@ -15,7 +15,11 @@
       "@angular-redux/store": ["./lib/src"]
     },
     "strict": true,
-    "skipLibCheck": true
+    "skipLibCheck": true,
+    "forceConsistentCasingInFileNames": true,
+    "noUnusedLocals": true,
+    "noUnusedParameters": true,
+    "pretty": true
   },
   "compileOnSave": false,
   "buildOnSave": false,