Skip to content

fix(desktop): disable AOF on Windows to prevent cygwin redis fork crash #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kaverjody wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(desktop): disable AOF on Windows to prevent cygwin redis fork crash #1170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion desktop/service-manager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,8 +467,15 @@ class ServiceManager {
redisDataDir,
'--save',
'60 1',
// Windows: disable AOF. The bundled cygwin portable redis cannot
// reliably fork() for AOF background rewrite, so enabling AOF
// crashes the redis child process and risks an empty appendonly
// file overwriting dump.rdb on the next start (data loss of all
// sessions). RDB snapshots (--save above) are sufficient for
// desktop single-user persistence. macOS bundles native redis
// where AOF rewrite fork works correctly, so keep AOF there.
'--appendonly',
'yes',
IS_WIN ? 'no' : 'yes',
'--maxclients',
'512',
];
Expand Down