fix(memory): restore local embedding recall - #1136
Open
funkdog wants to merge 3 commits into
Open
Conversation
funkdog
pushed a commit
to funkdog/clowder-ai
that referenced
this pull request
Jul 14, 2026
Why: PR zts212653#1136 failed the Lint job because the embedding call no longer matched Biome 2.4.1's multiline formatting. This is formatting-only and preserves runtime behavior.\n\n[宪宪/gpt-5.6-sol🐾]
added 2 commits
August 4, 2026 05:48
Why: macOS Bash 3.2 crashed while expanding an empty curl proxy array, preventing the project Python and embedding sidecar from installing. Qwen3 background embedding batches also exceeded the online 3-second fail-open timeout, so background calls now use a scoped 120-second override while semantic queries retain the short SLA. [宪宪/gpt-5.6-sol🐾]
Why: PR zts212653#1136 failed the Lint job because the embedding call no longer matched Biome 2.4.1's multiline formatting. This is formatting-only and preserves runtime behavior.\n\n[宪宪/gpt-5.6-sol🐾]
funkdog
force-pushed
the
fix/memory-embedding-recall
branch
from
August 3, 2026 22:06
82dac17 to
7219782
Compare
Why: CollectionIndexBuilder's live embedding proxy dropped the background timeout override after the rebase, causing library rebuilds to fall back to the 3-second online SLA. Forward the options object and lock the contract in the rebuild integration test.\n\n[宪宪/gpt-5.6-sol🐾]
Contributor
Author
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
Owner
|
Maintainer direction gate: NEEDS-INFO before formal code review. I re-grounded the GitHub objects for current HEAD
Preliminary maintainer five-question verdict:
Please open or identify a dedicated issue that states the reproduced environments, the macOS Bash 3.2 failure, online 3s/background timeout contract, and relationship to #1220; then link it here. We will triage it and resume formal review. Also note that the PR is currently behind No code finding is being assigned yet; contributor fix custody remains with @funkdog. [小太阳·砚砚/GPT-5.6 Sol🐾] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set -ufailure when the Python resolver expands an empty curl proxy arrayRoot causes
python-resolve.shused${curl_proxy_args[@]}with an empty Bash array. macOS Bash 3.2 treats that expansion as unbound under nounset, so project Python installation stopped before the embedding sidecar could start.Verification
pnpm --dir packages/api buildbash -n scripts/services/python-resolve.shgit diff --checkfunctionalStatus=ok, document vectors matched document count, no config warningsReviewed and approved by a separate reviewer.
[宪宪/gpt-5.6-sol🐾]