Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow redirects when downloading packages from Artifactory #293

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

t1m0thyj
Copy link
Member

@t1m0thyj t1m0thyj commented Oct 16, 2024

What It Does
Not sure why Artifactory started redirecting for the CLI package TGZ, but this PR should fix the failing nightly deployment:
https://github.com/zowe/zowe-cli-standalone-package/actions/runs/11357732730/job/31615012381

How to Test
Run cURL and notice it downloads an empty file, then add the -L flag and it works:

curl -fs -o cli-8.3.0.tgz https://zowe.jfrog.io/zowe/api/npm/npm-local-release/@zowe/cli/-/@zowe/cli-8.3.0.tgz
curl -fsL -o cli-8.3.0.tgz https://zowe.jfrog.io/zowe/api/npm/npm-local-release/@zowe/cli/-/@zowe/cli-8.3.0.tgz

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Timothy 😋

@t1m0thyj t1m0thyj merged commit c25b06f into master Oct 16, 2024
2 checks passed
@t1m0thyj t1m0thyj deleted the ci/fix-curl-download branch October 16, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants