Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added node v16 support for Zlux-Editor #336

Open
wants to merge 3 commits into
base: v2.x/staging
Choose a base branch
from

Conversation

Priyansh61
Copy link

Proposed changes

This PR addresses Issue: N.A.

This PR depends upon the following PRs: N.A.

Type of change

Please delete options that are not relevant.

  • Chore, repository cleanup, updates the dependencies.

PR Checklist

Please delete options that are not relevant.

  • If the changes in this PR are meant for the next release / mainline, this PR targets the "staging" branch.
  • My code follows the style guidelines of this project (see: Contributing guideline)
  • My changes generate no new warnings

Testing

Further comments

Signed-off-by: Priyansh61 <[email protected]>
Copy link
Member

@DivergentEuropeans DivergentEuropeans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great start 👍 but we'll want it to work for the recommended verison of Node. Please use Node 16 LTS 16.16.0 or 16.20.0

@@ -9,8 +9,7 @@
"test": "exit 0"
},
"dependencies": {
"@angular/cdk": "~6.3.3",
"angular-tree-component": "~7.2.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find here that we don't need it. A relic of a bygone era...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly! :)

@Priyansh61
Copy link
Author

Hi @DivergentEuropeans! Tested it on the node lts! Its working as intended...

zlux-editor.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

2 participants