-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added node v16 support for Zlux-Editor #336
base: v2.x/staging
Are you sure you want to change the base?
Conversation
Signed-off-by: Priyansh61 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great start 👍 but we'll want it to work for the recommended verison of Node. Please use Node 16 LTS 16.16.0 or 16.20.0
@@ -9,8 +9,7 @@ | |||
"test": "exit 0" | |||
}, | |||
"dependencies": { | |||
"@angular/cdk": "~6.3.3", | |||
"angular-tree-component": "~7.2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great find here that we don't need it. A relic of a bygone era...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly! :)
Hi @DivergentEuropeans! Tested it on the node lts! Its working as intended... zlux-editor.mp4 |
Proposed changes
This PR addresses Issue: N.A.
This PR depends upon the following PRs: N.A.
Type of change
Please delete options that are not relevant.
PR Checklist
Please delete options that are not relevant.
Testing
Further comments