Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove refs to Convenience build only in zwe-install and configure-zowe-zosmf-workflow #4128

Merged

Conversation

janan07
Copy link
Collaborator

@janan07 janan07 commented Feb 3, 2025

Describe your pull request here: Remove refs to Convenience build only in zwe-install and configure-zowe-zosmf-workflow

To address:zowe/zowe-install-packaging#4163

List the file(s) included in this PR: zwe-instal.mdl and configure-zowe-zosmf-workflow,md

After creating the PR, follow the instructions in the comments.

@janan07 janan07 added area: install and config Issues related to z/OS install and config release: V3 Zowe V3 content review: sme Needs review by an SME labels Feb 3, 2025
@janan07 janan07 requested a review from pavelzlatnik February 3, 2025 13:15
Copy link

github-actions bot commented Feb 3, 2025

😺 Thank you for creating this PR! To publish your content to Zowe Docs, follow these required steps.

  • Add the label review: doc.
  • Identify your content topic with a label. (Examples: area: apiml, area: cli, area: install and config, etc.)
  • Specify the major Zowe release(s) for your content. (Examples: release: V1, release: V2, release: V3)
    • If adding content that needs to be removed from V3 documentation, add the V3 N/A tag.
  • Select the master branch if your PR updates content that is on the live site. Select docs-staging if your PR updates content for a future release.
  • Notify the Doc Squad about this PR. If you don't know whom should review your content, message the #zowe-doc Slack channel. If you know which Doc Squad writer should approve your content, add that person as a reviewer.

Need help? Contact the Doc Squad in the #zowe-doc Slack channel.

@@ -99,7 +99,7 @@ The **Create configuration** step is mandatory. A valid zowe.yaml is required to

This step consumes the zowe.yaml configuration file you created in the previous step. It contains three sub-steps:

1. **(Optional) Run the Zowe install (only for convenience build)**. This step is required only for the convenience build. It runs the `zwe install` command.
1. **Run the Zowe install**. This step is required only for the convenience build. It runs the `zwe install` command.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is removing this language that specified the Convenience build option adequate to resolve this issue?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, you are right, remove also second sentence. This step is required only for the convenience build.

Copy link

github-actions bot commented Feb 3, 2025

@github-actions github-actions bot temporarily deployed to pull request February 3, 2025 13:20 Inactive
Copy link
Collaborator

@pavelzlatnik pavelzlatnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my suggestions

@@ -99,7 +99,7 @@ The **Create configuration** step is mandatory. A valid zowe.yaml is required to

This step consumes the zowe.yaml configuration file you created in the previous step. It contains three sub-steps:

1. **(Optional) Run the Zowe install (only for convenience build)**. This step is required only for the convenience build. It runs the `zwe install` command.
1. **Run the Zowe install**. This step is required only for the convenience build. It runs the `zwe install` command.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, you are right, remove also second sentence. This step is required only for the convenience build.

@@ -6,13 +6,10 @@

## Description

After you extract Zowe convenience build, you can run this command to install
After installation via SMP/E Zowe convenience build, run this command to install
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modify this, to: After installation of Zowe via SMP/E, PSWI or convenience build, run this command to install sample modules and some load modules into MVS data sets.

@github-actions github-actions bot temporarily deployed to pull request February 4, 2025 09:49 Inactive
Copy link
Collaborator

@pavelzlatnik pavelzlatnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@janan07 janan07 merged commit 688c85f into master Feb 4, 2025
3 of 4 checks passed
@janan07 janan07 deleted the janan07/fix-zowe-install-command/step-#4163-install-pkging branch February 4, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: install and config Issues related to z/OS install and config release: V3 Zowe V3 content review: sme Needs review by an SME
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants