-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infinispan doc updates #4101
base: docs-staging
Are you sure you want to change the base?
Infinispan doc updates #4101
Conversation
Signed-off-by: Pavel Jareš <[email protected]>
😺 Thank you for creating this PR! To publish your content to Zowe Docs, follow these required steps.
Need help? Contact the Doc Squad in the #zowe-doc Slack channel. |
Signed-off-by: Pavel Jareš <[email protected]>
Signed-off-by: Andrew Jandacek <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending changes to Addressing Network Requirements
You are missing this page https://docs.zowe.org/stable/user-guide/address-network-requirements |
Signed-off-by: Andrew Jandacek <[email protected]>
Signed-off-by: Andrew Jandacek <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending changes to Addressing Network Requirements per Sean's suggestion
@@ -68,19 +64,15 @@ Configure Infinispan as a storage solution through the Caching service by settin | |||
caching-service: | |||
storage: | |||
mode: infinispan | |||
infinispan: | |||
infinispan: | |||
jgroups.port: 7098 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand this works, but I think we usually just nest the properties
jgroups.port: 7098 | |
groups: | |
port: 7098 |
* **`zowe.components.caching-service.storage.infinispan.jgroups.host`** | ||
|
||
(OPTIONAL)The default value is taken from zowe hostname. The hostname used by Infinispan to synchronise data among cahing-service instances. | ||
|
||
|
||
* **`zowe.components.caching-service.storage.infinispan.keyExchange.port`** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no use case for infinispan running off-platform, right?
|
||
(OPTIONAL)The default value is `7098`. The port number used by Infinispan to synchronise data among cahing-service instances. | ||
(Optional) The default value is `7600`. The port number is used by Infinispan to synchronise data among Caching Service instances. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is going with 3.2, I'd keep the 7098, I believe we need to update that in the defaults.yaml
|
||
(OPTIONAL)The default value is `7118`. The port number used by Infinispan to exchange encryption key among cahing-service instances. | ||
(Optional) The default value is `7601`. The port number is used by Infinispan to exchange encryption key among Caching Service instances. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is not defined in https://github.com/zowe/zowe-install-packaging/blob/v3.x/staging/files/defaults.yaml
Default is 7118
infinispan: | ||
jgroups.port: 7098 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same thing about being consistent, use the nested format
dataLocation: /global/zowe/workspace/caching-service/data | ||
indexLocation: /global/zowe/workspace/caching-service/index |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a comment to the example about needing to be in a non-shared filesystem (tendency to copy-paste)
Signed-off-by: Pavel Jareš <[email protected]>
Version 3.1 is changed by #4171 |
| 7099 | zowe.components.caching-service.storage.infinispan.jgroups.keyExchange.port | The port at which the key server in Infinispan is listening. If the port is not available, the next port is probed, up to port+5. Used by the key server (server) to create an SSLServerSocket and by clients to connect to the key server. | ||
| 7098 | zowe.components.caching-service.storage.infinispan.jgroups.port | Bind port for the socket that is used to form an Infinispan cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be 7601 and 7600, right?
Signed-off-by: Pavel Jareš <[email protected]>
Signed-off-by: Andrew Jandacek <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and edited by doc squad
Signed-off-by: Pavel Jareš <[email protected]>
This PR contains two versions on new file
api-mediation-infinispan.md
.The updates is to respect changes from these PRs:
The text in
versioned_docs/version-v3.0.x/extend/extend-apiml/api-mediation-infinispan.md
is valid for 3.0 and 3.1.The text in
docs/extend/extend-apiml/api-mediation-infinispan.md
will be valid since 3.2.