Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retire Python 3.8 #291

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Retire Python 3.8 #291

merged 3 commits into from
Dec 18, 2024

Conversation

dataflake
Copy link
Member

This PR sets Python 3.9 as the oldest supported Python version and it removes Python 3.8 support from this package as well.

@dataflake dataflake self-assigned this Dec 17, 2024
@icemac
Copy link
Member

icemac commented Dec 18, 2024

@dataflake O no, you were way quicker than me and I walked top to bottom through my inbox. I'll merge my PR into yours.

@d-maurer d-maurer mentioned this pull request Dec 18, 2024
Merged
icemac
icemac approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12388414494

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 18.363%
Totals Coverage Status
Change from base Build 12194986695: 0.0%
Covered Lines: 164
Relevant Lines: 724
💛 - Coveralls

@dataflake dataflake merged commit 5cba552 into master Dec 18, 2024
12 checks passed
@dataflake dataflake deleted the dataflake/retire_python_38 branch December 18, 2024 08:02
@mauritsvanrees
Copy link
Member

@dataflake Does this mean you would be fine with zc.buildout dropping Python 3.8 support? The upcoming 4.0.0 would be a good time for that.

@mauritsvanrees mauritsvanrees mentioned this pull request Dec 18, 2024
Open
@dataflake
Copy link
Member Author

I'm fine with that now that we have decided to drop it as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-maurer d-maurer d-maurer approved these changes

@icemac icemac icemac approved these changes

@mauritsvanrees mauritsvanrees Awaiting requested review from mauritsvanrees

Assignees

@dataflake dataflake

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dataflake @icemac @coveralls @mauritsvanrees @d-maurer