Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Python 3.12 to non-future and change with-future-python behavior #211

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

dataflake
Copy link
Member

This PR does two things:

  • move Python 3.12 to the list of standard non-future Pythons
  • prepare places that want to use future Pythons by using py313
  • redefine FUTURE_PYTHON_VERSION to an empty string
  • only render future python-related template items if FUTURE_PYTHON_VERSION is not empty

With the last two changes individual packages do not need to turn off their with-future-python flag during those times when the Python release is finished and no prerelease exists for the next Python version.

@dataflake dataflake requested a review from icemac October 5, 2023 05:39
@dataflake
Copy link
Member Author

A manual test on the DocumentTemplate repo shows that the only change individual packages will need for "official" Python 3.12 support is adding the trove classifier in setup.py.

Copy link
Member

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the changes.
The first alpha of 3.14 is due to be released in about 2 weeks, so we are prepared.

@dataflake dataflake merged commit ca45ff1 into master Oct 5, 2023
@dataflake dataflake deleted the future_python_switch branch October 5, 2023 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants