Skip to content

Comments

limit graphql to non breaking version#1627

Merged
Tooyosi merged 2 commits intomasterfrom
rails-6.0-limit-graphql
Apr 28, 2025
Merged

limit graphql to non breaking version#1627
Tooyosi merged 2 commits intomasterfrom
rails-6.0-limit-graphql

Conversation

@Tooyosi
Copy link
Collaborator

@Tooyosi Tooyosi commented Apr 23, 2025

Pin graphql to 1.12 (pending proper graphql upgrades: #1623). Fixes the failed run here
Require ostruct in application.rb for graphql 1.12

@Tooyosi Tooyosi requested a review from yuenmichelle1 April 23, 2025 19:35
gem 'simple_form'
gem 'pundit', "~> 2.2.0"
gem 'graphql'
gem 'graphql', "1.12"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem graphql should appear before pundit.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

@yuenmichelle1
Copy link
Contributor

We'll just have to be vigilant for any of the breaking changes from 1.9.x -> 1.12.0
https://github.com/rmosolgo/graphql-ruby/blob/master/CHANGELOG.md#1120-20-january-2021

@Tooyosi Tooyosi merged commit 81549d8 into master Apr 28, 2025
3 checks passed
@Tooyosi Tooyosi deleted the rails-6.0-limit-graphql branch April 28, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants