Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix raw output
Context
When using zonemaster/zonemaster-engine#1302 the raw ouput is broken as the CLI was relying on the fact that module / testcase / tag to strip them from the message.
Instead of changing the regex, let's use a new method that return only the message arguments, which is less error prone.
Changes
$entry->argstr
instead of removing the prefix of the output of$entry->string
.How to test this PR
Check that the raw ouput working correctly, in particular check that after the message tag only the arguments are displayed and no garbage of any sort.
Before the PR
After