Skip to content

Conversation

@GallegoSav
Copy link

The default script was only assuming 3D cartesian system for computing the source positions, aka SetSourceWindow.

This is ok for simulation when the pointing is static but not as soon as you use an orientation file with a galactic pointing.

I just modified a bit the script so that now the coordinate system the user want is taken from the mimrec configuration file.
Then it passes the correct position and coordinate system to SetSourceWindow, which is used later for computing the ARM.

@zoglauer
Copy link
Owner

Hi Savitri,

SensitivityOptimizer was designed to calculate the average sensitivity for an instrument always pointing upwards - away from Earth.
It cannot handle any pointing in Galactic coordinates, that's why I had fixed the event selections coordinates that way.

I probably should have it spit out an error message if we have another coordinate system.

Can you let me know what prompted your change?

Best,
Andreas

@GallegoSav
Copy link
Author

Hi Andreas,

What was the reason it cannot handle the pointing in Galactic coordinates ? I took the part from mimrec where you defined how to set the source windows when there is a galatic pointing in order to compute properly the ARM cut.

I wanted to change that because in reality you never always point to the source and I wanted to know what would be the impact on the sensitivity with a real pointing.

@zoglauer
Copy link
Owner

It's how it calculates the average sensitivity in scanning mode. It has to point upwards for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants