-
Notifications
You must be signed in to change notification settings - Fork 37
Add different coordinate systems for the SensitivityOptimiser #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop-cosi
Are you sure you want to change the base?
Conversation
|
Hi Savitri, SensitivityOptimizer was designed to calculate the average sensitivity for an instrument always pointing upwards - away from Earth. I probably should have it spit out an error message if we have another coordinate system. Can you let me know what prompted your change? Best, |
|
Hi Andreas, What was the reason it cannot handle the pointing in Galactic coordinates ? I took the part from mimrec where you defined how to set the source windows when there is a galatic pointing in order to compute properly the ARM cut. I wanted to change that because in reality you never always point to the source and I wanted to know what would be the impact on the sensitivity with a real pointing. |
|
It's how it calculates the average sensitivity in scanning mode. It has to point upwards for that. |
The default script was only assuming 3D cartesian system for computing the source positions, aka
SetSourceWindow.This is ok for simulation when the pointing is static but not as soon as you use an orientation file with a galactic pointing.
I just modified a bit the script so that now the coordinate system the user want is taken from the mimrec configuration file.
Then it passes the correct position and coordinate system to
SetSourceWindow, which is used later for computing the ARM.