Skip to content

Add multi-value dictionary documentation #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add multi-value dictionary documentation #15

wants to merge 3 commits into from

Conversation

StarKhan6368
Copy link
Contributor

  • Centralize dictionary documentation

@StarKhan6368
Add multi-value dictionary documentation
8776ecf 
- Centralize dictionary documentation
@StarKhan6368 StarKhan6368 mentioned this pull request Apr 29, 2025
Merged
10 tasks
ketan
ketan reviewed May 9, 2025
View reviewed changes
Copy link
Contributor

@ketan ketan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please run bundle exec rake check to ensure no broken links (atleast in these pages).

@StarKhan6368
Merge branch 'main' into multi-value-dict
d580f28 
# Conflicts:
#	documentation/contract_tests.md
#	documentation/service_virtualization_tutorial.md
@StarKhan6368
Use heading tag for consistency
29d6c07
@StarKhan6368
Copy link
Contributor Author

StarKhan6368 commented May 9, 2025 •
edited
Loading

LGTM. Please run bundle exec rake check to ensure no broken links (atleast in these pages).

I reviewed the check and did not find any issues created by this PR that need fixing,
It does mention that links are http instead of https, which I believe is expected,
There are, however, a few broken links in contract_test and service_virtualization that were not caused by this PR. Might need additional context to understand where they were supposed to direct the reader

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ketan ketan ketan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StarKhan6368 @ketan