Add u16/32/64 #206
Add u16/32/64 #206
Conversation
| let bit_len = 32; | ||
|
|
||
| // range check | ||
| let ignore_ = bits::to_bits(bit_len, val); |
There was a problem hiding this comment.
usually the syntax is let _ = or let _bits =
There was a problem hiding this comment.
the current rule doesn't allow starting with _, maybe it is time to change this rule?
| } | ||
|
|
||
| fn Uint64.less_eq_than(self, rhs: Uint64) -> Bool { | ||
| return comparator::less_eq_than(self.bit_len, self.inner, rhs.inner); |
There was a problem hiding this comment.
we should also implement add, sub, etc.
this is when having a bit_len field would be interesting... because theoretically we could track how many bits max the result of an operation is, and only trigger a range check when we might be above 8 bits for u8. But in the absence of that we can simply perform a range check after every operation
There was a problem hiding this comment.
To take it further, maybe we can make it support builtin operations, such as + -, by mapping these operations to these functions. #214
Add builtin types: u16/32/64
Increate test coverage for these newly added stdlib