Repository navigation
feat(offline): keep the last export across reloads - #213
Merged
Merged
Conversation
The signing panel saves each action's exported filename and fee in sessionStorage, keyed by network, vault and proposal, so a reload or a visit to another page keeps step 2's command and the signed-fee check. Start over clears it, and a broadcast stops saving it.
After a reload the form is empty, and reading it once the proposal was broadcast could fail. The pending summary now comes from the last export in this page load, and is left out when there is none.
A signed new proposal cannot be matched to an export, so a kept fee could be applied to another proposal's file. Only the proposal page, keyed by proposal hash, keeps its exports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a proposal's page, the offline signing panel now keeps each action's exported filename and fee in
sessionStorage(per network, vault and proposal hash), so step 2's command and the signed-fee check survive a reload or navigation. Start over clears it, and a broadcast removes it. The new-proposal page keeps nothing across reloads.The new-proposal page's pending summary now comes from the last export instead of the live form.
Follow-up: the summary is matched by vault only, not by proposal hash.
🤖 Generated with Claude Code