[WIP] Attempt to verify reverse engineered keys failing #127
Conversation
… verification, unclear why
| logging.info(f'Expected: {hex(message)}') | ||
| logging.info(f'Got: {hex(decrypted)}') | ||
|
|
||
| if pow(signature, rsa_key.e, rsa_key.n) == message: |
There was a problem hiding this comment.
This fails and am not sure why. Calling RSA verification directly also fails. I didn't understand how the bytes just don't match
| if sig1.timestamp and first_seen <= sig1.timestamp <= last_seen: | ||
| timestamp_1_covered = True | ||
| try: | ||
| logging.info(f"Validating correct signature {sig1.id} with key {key['keyData']}") |
There was a problem hiding this comment.
seems that key doesn't have a field called keyData,
it only has what is included here: https://github.com/zkemail/archive.zk.email/blob/main/src/app/api/key/route.ts#L31
so we will always get a value exception when accessing key["keyData"] and validate_signature never gets called
for me, the following seems to fix it, and i get successful validations:
after for key in matching_keys:, add:
key_value = key["value"] # 'v=DKIM1; k=rsa; p=MIIBIjA...'}
keyBase64 = decode_dkim_tag_value_list(key_value).get('p')
if not keyBase64:
logging.error(f"Key data not found in {key_value}")
continue
replace all key["keyData"] with keyBase64
and in the import section at the beginning of the file add:
sys.path.append(str(Path(__file__).absolute().parent.parent))
from dkim_util import decode_dkim_tag_value_list
| continue | ||
| # logging.info(f"might theoretically run gcd solver for {dsp} and timestamps {sig1.timestamp} and {sig2.timestamp}") | ||
| shouldFindMatch = await check_for_matching_key_period(dsp, sig1, sig2) | ||
| if shouldFindMatch: |
There was a problem hiding this comment.
if i remove the call to check_for_matching_key_period and also remove the if shouldFindMatch condition here,
and thus always run find_key_for_signature_pair, then i actually reach a successful validation in validate_signature, (via find_key_for_signature_pair > check_adjacent_sigs > validate_signature)
No description provided.