Handle non-permitted params when comparing rules to request body #1
+57
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mecampbellsoup
commented
Mar 29, 2017
| context "when the request body does not adhere to the rules format" do | ||
| let(:name) { 1_000 } | ||
| context "when a non-specified parameter is included in the request body" do | ||
| let(:params) { { name: "M@", email: "[email protected]" } } |
Contributor
Author
There was a problem hiding this comment.
@kurko do you think 'extra' params should simply be ignored, or should we actually mark the request as being invalid (this is what we're doing now).
Example:
Rules = { data: Hash }
# the `foo` param is not whitelisted
param = { data: {}, foo: "bar" }
There was a problem hiding this comment.
Ignored, I think. strong parameters does that.
Contributor
Author
There was a problem hiding this comment.
The two examples below represent (1) ignoring them, not adding an error but filtering out the non-permitted param, or (2) adding an error as we do now in OTX.
Contributor
Author
There was a problem hiding this comment.
@kurko spoke with Jake about this: https://zipmark.slack.com/archives/C32CZ771B/p1490814011401531
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.