Improve client timeout options (#2383) #3844
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for zio-http ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
987Nabil
force-pushed
the
timeout-client-improvement
branch
from
72a5d40 to
9d4223f
Compare
987Nabil
force-pushed
the
timeout-client-improvement
branch
from
9d4223f to
6680b7c
Compare
kyri-petrou
reviewed
Dec 10, 2025
| .schedule( | ||
| new Runnable { | ||
| override def run(): Unit = { | ||
| AsyncBodyReader.this.synchronized { |
Collaborator
There was a problem hiding this comment.
This is a bit confusing (I've actually never seen this syntax before). Maybe just use this.synchronized?
Comment on lines
+122
to
+126
| val currentTask = timeoutTask.get() | ||
| if (currentTask != null) { | ||
| currentTask.cancel(false) | ||
| timeoutTask.set(null) | ||
| } |
Collaborator
There was a problem hiding this comment.
If you wrap this in synchronized you can simply use a var for timeoutTask instead of an AtomicReference.
Comment on lines
+182
to
+211
| timeoutMillis.foreach { timeoutMillis => | ||
| val task = ctx | ||
| .channel() | ||
| .eventLoop() | ||
| .schedule( | ||
| new Runnable { | ||
| override def run(): Unit = { | ||
| AsyncBodyReader.this.synchronized { | ||
| state match { | ||
| case State.Direct(cb) if !readingDone => | ||
| cb.fail( | ||
| new IOException( | ||
| s"Body read timeout: server stopped sending data after ${timeoutMillis}ms", | ||
| ), | ||
| ) | ||
| readingDone = true | ||
| if (ctx.channel().isOpen) { | ||
| ctx.channel().close(): Unit | ||
| } | ||
| case _ => // Already completed or not connected | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| timeoutMillis, | ||
| TimeUnit.MILLISECONDS, | ||
| ) | ||
| timeoutTask.set(task) | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Isn't this the same code as above? Maybe extract it all into a method if that's the case?
Comment on lines
+238
to
+242
| val currentTask = timeoutTask.get() | ||
| if (currentTask != null) { | ||
| currentTask.cancel(false) | ||
| timeoutTask.set(null) | ||
| } |
Collaborator
There was a problem hiding this comment.
This is being used everywhere and doesn't have any dependency on the local vals. Maybe extract it into a method to keep things DRY
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2383