Feature/add cancellation support #1510
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add CancellationToken class for operation cancellation - Add CancelledException for cancelled operations - Integrate cancellation into BaseOptions, QueryOptions, MutationOptions - Implement cancellation handling in QueryManager - Add queryCancellable() and mutateCancellable() convenience methods - Add comprehensive test suite (7 tests) - Add usage documentation
jorg1piano
reviewed
Dec 9, 2025
|
|
||
| 3. **Error Handling**: Cancelled operations will complete with an `OperationException` containing a `CancelledException` as the `linkException`. | ||
|
|
||
| 4. **Network Cleanup**: Cancelling an operation will attempt to cancel the underlying network request, but depending on the transport layer and server, the request may still complete on the server side. |
There was a problem hiding this comment.
can't really see how it cancels the underlying request? can you explain?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As needed since 6 years here is cancellation support #181
-> no breaking changes
-> all tests pass