added Input Data POJO#1100
Conversation
sonalgoyal
left a comment
sonalgoyal
left a comment
There was a problem hiding this comment.
lookgs good overall, added few extra comments
|
|
||
| public interface IData<D, R, C> { | ||
| List<ZFrame<D, R, C>> getData(); | ||
| InputType getInputType(); |
| import zingg.common.client.cols.ZidAndFieldDefSelector; | ||
| import zingg.common.core.executor.processunit.IDataProcessUnit; | ||
|
|
||
| public class ZidAndFieldSelectorUnit<D, R, C> implements IDataProcessUnit<D, R, C> { |
There was a problem hiding this comment.
ColSelector...which takes iselector
| @@ -0,0 +1,77 @@ | |||
| package zingg.common.core.data; | |||
| } | ||
|
|
||
| @Override | ||
| public InputType getInputType() { |
|
|
||
| protected List<ZFrame<D, R, C>> data; | ||
|
|
||
| public IDataImpl(List<ZFrame<D, R, C>> data) { |
There was a problem hiding this comment.
add another constructor which takes ZFrame<> data... so its easier to constructo this object at other places
There was a problem hiding this comment.
is there a way to keep thie list of data final?
| import zingg.common.client.ZFrame; | ||
| import zingg.common.client.ZinggClientException; | ||
|
|
||
| public interface IDataProcessUnit<D, R, C> { |
| public IData<D, R, C> getData(IArguments args, PipeUtilBase<S, D, R, C> p) throws ZinggClientException{ | ||
| ZFrame<D,R,C> data = p.read(true, true, args.getNumPartitions(), true, args.getData()); | ||
| return data; | ||
| return new IDataImpl<D, R, C>(new ArrayList<>(List.of(data))); |
There was a problem hiding this comment.
this will go once oyu have the constructor in DataImpl/ZData
| if (secondary == null) { | ||
| secondary = zFrame; | ||
| } else { | ||
| secondary = secondary.union(zFrame); |
There was a problem hiding this comment.
no we should not be doing a union here. we should just add all the frames one after the other
There was a problem hiding this comment.
that gives us flexibility to do multi joins etc as needed in the downstream executors
| @@ -0,0 +1,6 @@ | |||
| package zingg.common.core.data; | |||
| } | ||
|
|
||
| @Override | ||
| public long count() { |
There was a problem hiding this comment.
would be cool to save it once computed
There was a problem hiding this comment.
will check for the way
# Conflicts: # common/core/src/main/java/zingg/common/core/executor/blockingverifier/VerifyBlocking.java
5 participants
No description provided.