Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support customize pre color #60

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Support customize pre color #60

wants to merge 4 commits into from

Conversation

Folyd
Copy link
Member

@Folyd Folyd commented May 4, 2022

No description provided.

@Folyd Folyd marked this pull request as ready for review May 5, 2022 09:18
@Folyd Folyd requested a review from KernelErr May 5, 2022 09:18
KernelErr
KernelErr reviewed May 5, 2022
View reviewed changes
Copy link
Collaborator

@KernelErr KernelErr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The values set did appear in the style sheet. But seems not to take effect on any element. Is it on purpose?

@Folyd
Copy link
Member Author

Folyd commented May 8, 2022

The values set did appear in the style sheet. But seems not to take effect on any element. Is it on purpose?

Yes, the pre color will be overridden by the custom syntax highlight theme. If you disable the highlight_code, the pre color will work. Maybe we need a better solution to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KernelErr KernelErr KernelErr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Folyd @KernelErr