(feature) --json option as output #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stonebk
suggested changes
Aug 23, 2021
| --json flag will generate `filename.json` | ||
|
|
||
| ``` | ||
| npx webpack-stats-duplicates --json <filename.json> .\stats.json |
There was a problem hiding this comment.
Is the backslash instead of forwards slash windows? Maybe just remove it to avoid confusion?
- .\stats.json
+ stats.json|
|
||
| var jsonArgHasBeenPassed = argv.json === ''; | ||
| if(jsonArgHasBeenPassed) { | ||
| printDuplicatesToJson(duplicates, 'blanky.json'); |
There was a problem hiding this comment.
blanky.json should not be hard-coded
|
|
||
| module.exports = function (duplicates, filename) { | ||
| if(duplicates) { | ||
| duplicates = duplicates.map( dup => { |
There was a problem hiding this comment.
Do we need to map the object at all? Can we just write the duplicates object directly? I forget what other properteis are in that object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Brian,
Amazing package you created, I would like to add --json option as output, to connect the output to a Github Action.
Can these changes make it into your npm package?
Thank you