Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIP-8457 remove unnecessary kfp dependencies #300

Merged
merged 2 commits into from
May 31, 2024
Merged

AIP-8457 remove unnecessary kfp dependencies #300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a0b570
AIP-8457 remove kfp dependencies
talebzeghmi May 31, 2024
6938114
dependency cleanup
talebzeghmi May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion kfp/_auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@
from google.auth.transport.requests import Request
import google.oauth2.credentials
import google.oauth2.service_account
import requests_toolbelt.adapters.appengine
# AIP-8457(talebz): WFSDK requests-toolbelt dependency breaks KFNB "pip install poetry"
# import requests_toolbelt.adapters.appengine
from webbrowser import open_new_tab
import requests
import json
Expand Down
3 changes: 2 additions & 1 deletion kfp/components/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,5 @@
from ._components import *
from ._python_op import *
from ._python_to_graph_component import *
from ._component_store import *
# AIP-8457(talebz): WFSDK requests-toolbelt dependency breaks KFNB "pip install poetry"
# from ._component_store import *
6 changes: 3 additions & 3 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
""",
install_requires=[
"requests",
"urllib3<2.0.0", # see requests break https://github.com/kubeflow/pipelines/pull/9323
"boto3",
"pylint",
# required for KFP
Expand All @@ -36,8 +35,9 @@
"kubernetes>=8.0.0,<27",
"protobuf>=3.13.0,<4",
"pyyaml>=5.3,<7",
"requests-toolbelt>=0.8.0,<1",
"uritemplate>=3.0.1,<4",
# AIP-8457(talebz): WFSDK requests-toolbelt dependency breaks KFNB "pip install poetry"
# "requests-toolbelt>=0.8.0,<1",
# "uritemplate>=3.0.1,<4",
],
tests_require=["coverage"],
extras_require={
Expand Down
Loading