Fix

zillow · Aug 23, 2024 · aa1fd17 · aa1fd17
1 parent 81e7f6c
commit aa1fd17
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/metaflow/plugins/aip/aip_cli.py b/metaflow/plugins/aip/aip_cli.py
@@ -361,7 +361,7 @@ def run(
         notify_on_success=notify_on_success,
         sqs_url_on_error=sqs_url_on_error,
         sqs_role_arn_on_error=sqs_role_arn_on_error,
-        add_default_cards=True,
+        add_default_cards=add_default_cards,
     )
 
     if yaml_only:
@@ -559,7 +559,7 @@ def create(
         notify_on_success=notify_on_success,
         sqs_url_on_error=sqs_url_on_error,
         sqs_role_arn_on_error=sqs_role_arn_on_error,
-        add_default_cards=True,
+        add_default_cards=add_default_cards,
     )
 
     if yaml_only:
@@ -680,7 +680,7 @@ def make_flow(
     notify_on_success,
     sqs_url_on_error,
     sqs_role_arn_on_error,
-    add_default_cards=True,
+    add_default_cards,
 ):
     """
     Analogous to step_functions_cli.py

diff --git a/metaflow/plugins/aip/aip_metaflow_step.py b/metaflow/plugins/aip/aip_metaflow_step.py
@@ -52,8 +52,9 @@ def _write_card_artifacts(
         try:
             with open(file_name, "w") as card_file:
                 card_file.write(card.get())
-        except Exception as e:
-            logging.exception(f"Failed to write card {i} of type {card.type}: {e}")
+        except Exception:
+            logging.error(f"Failed to write card {i} of type {card.type}")
+            raise
         i = i + 1