fix(build): remove asm_legacy references for latest Zig

[neoto]

Resolves #2525

The minimum version now corresponds to this commit - which matches what I'm currently running - but the build actually started failing since #30018. I don't use Nix so things related to that probably need to be addressed additionally.

I guess I should note that the formatter reordered the imports, but I can revert these changes if necessary...

[Techatrix]

The following two function are now unused and should be removed:

• https://github.com/neoto/zls/blob/e8e542a2ce47ce73a6562edf586d8f63d65e1e2c/src/ast.zig#L120C4-L120C23
• https://github.com/neoto/zls/blob/e8e542a2ce47ce73a6562edf586d8f63d65e1e2c/src/ast.zig#L206

The following test should also be removed:

• https://github.com/neoto/zls/blob/e8e542a2ce47ce73a6562edf586d8f63d65e1e2c/tests/lsp_features/semantic_tokens.zig#L1880

The minimum version now corresponds to this commit

The minimum_zig_version should be an exact version that is provided on ziglang.org. The prebuilt Zig binaries are currently not updating so this PR cannot be merged until then.

I don't use Nix so things related to that probably need to be addressed additionally.

I can take care of that before merging.

I guess I should note that the formatter reordered the imports, but I can revert these changes if necessary...

Yes, that should be reverted.

[neoto]

Thank you for the review!

The following two function are now unused and should be removed:

• https://github.com/neoto/zls/blob/e8e542a2ce47ce73a6562edf586d8f63d65e1e2c/src/ast.zig#L120C4-L120C23
• https://github.com/neoto/zls/blob/e8e542a2ce47ce73a6562edf586d8f63d65e1e2c/src/ast.zig#L206

The following test should also be removed:

• https://github.com/neoto/zls/blob/e8e542a2ce47ce73a6562edf586d8f63d65e1e2c/tests/lsp_features/semantic_tokens.zig#L1880

Done

The minimum version now corresponds to this commit

The minimum_zig_version should be an exact version that is provided on ziglang.org. The prebuilt Zig binaries are currently not updating so this PR cannot be merged until then.

I've reverted that change because the rest is otherwise valid, plus someone building ZLS from scratch will probably be using a newer Zig version anyway. Once the binaries start being updated again, the version change can be revisited - what do you think?

I guess I should note that the formatter reordered the imports, but I can revert these changes if necessary...

Yes, that should be reverted.

Done. Would be nice if the repo used a config with import sorting disabled, but that currently doesn't seem to be supported with zls.json.

[Techatrix]

I've reverted that change because the rest is otherwise valid, plus someone building ZLS from scratch will probably be using a newer Zig version anyway. Once the binaries start being updated again, the version change can be revisited - what do you think?

It doesn't matter if the minimum_zig_version is updated or not. This PR will fix building ZLS against master branch of Zig but in return break building against the latest prebuilt binary. I prefer to support the latter until they are back in sync at which point there is no longer a reason to withhold from updating the minimum_zig_version.

[neoto]

It doesn't matter if the minimum_zig_version is updated or not. This PR will fix building ZLS against master branch of Zig but in return break building against the latest prebuilt binary. I prefer to support the latter until they are back in sync at which point there is no longer a reason to withhold from updating the minimum_zig_version.

Alrighty. I see Andrew mentioned on Zulip that he'll update the script soonish so I hope we don't have to wait too long.