minimum/maximum builtins #9448
Merged
minimum/maximum builtins #9448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, and i also made sure to implement the float semantics in comptime: if either argument is nan, the other is returned. |
|
CI errors seem unrelated |
nektro
reviewed
Jul 25, 2021
src/stage1/ir.cpp
Outdated
| static void float_negate(ZigValue *out_val, ZigValue *op) { | ||
| out_val->type = op->type; | ||
| if (op->type->id == ZigTypeIdComptimeFloat) { | ||
| bigfloat_negate(&out_val->data.x_bigfloat, &op->data.x_bigfloat); | ||
| } else if (op->type->id == ZigTypeIdFloat) { | ||
| switch (op->type->data.floating.bit_count) { | ||
| case 16: | ||
| out_val->data.x_f16 = f16_neg(op->data.x_f16); |
There was a problem hiding this comment.
That must have been an accident. Thanks for the find :)
Snektron
force-pushed
the
minimum-maximum
branch
3 times, most recently
from
56ea0ed to
bc057c0
Compare
Snektron
force-pushed
the
minimum-maximum
branch
from
bc057c0 to
2c95d81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds
@minimumand@maximumbuiltin functions. The main use case for these is SIMD (See #903), though they work on scalars as well.For floats, this uses the
llvm.maxnumandllvm.minnumintrinsics. Note that x86_64vminpsandvmaxpshave different semantics, and so these generate some extra instructions:On other architectures (riscv and arm) this shouldn't be a problem.