libc: implement common abs for various integer sizes
#23893
+65
−428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrp
reviewed
May 15, 2025
alexrp
reviewed
May 15, 2025
jayschwa
reviewed
May 15, 2025
That means you can delete the duplicate libc implementations. |
kada49
force-pushed
the
common-impl-libc-abs
branch
from
e730278 to
4bbb5df
Compare
alexrp
reviewed
May 17, 2025
alexrp
reviewed
May 19, 2025
alexrp
reviewed
May 19, 2025
alexrp
approved these changes
May 19, 2025
|
I tried this locally (linux) and it works with |
Previously all the functions that were exported were handled equally, though some may exist and some not inside the same file. Moving the checks inside the file allows handling different functions differently
Co-authored-by: Alex Rønne Petersen <[email protected]>
Co-authored-by: Alex Rønne Petersen <[email protected]>
kada49
force-pushed
the
common-impl-libc-abs
branch
from
9e146a3 to
18a2714
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented common libc functions:
absimaxabslabsllabsabs functions for floating point numbers are already implemented in compiler_rt.