Skip to content

Add zig logo the the compiler binary on Windows #23395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Add zig logo the the compiler binary on Windows #23395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5de4b99
Add zig logo the the compiler binary on Windows
LucasSantos91 Mar 28, 2025
1ca7a11
Avoid calling `addWin32ResourceFile` when `only_c` flag is set
LucasSantos91 Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions build.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,9 @@ pub fn build(b: *std.Build) !void {
});
exe.pie = pie;
exe.entitlements = entitlements;
if (!only_c) {
exe.addWin32ResourceFile(.{ .file = b.path("rsc/resources.rc") });
}

exe.build_id = b.option(
std.zig.BuildId,
Expand Down
1 change: 1 addition & 0 deletions rsc/resources.rc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
MAINICON ICON "zig-mark.ico"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Missing a trailing newline.

Binary file added rsc/zig-mark.ico
View file
Open in desktop
Binary file not shown.
Loading