Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler errors in std.process and std.Build.Step.Compile #22511

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

apwadkar
Copy link
Contributor

Fixes

_ = &std.process.changeCurDirC;
_ = &std.Build.Step.Compile.dependsOnSystemLibrary;

from #20505.

Looks like chdirC was renamed chdirZ but that wasn't reflected in the std.process alias. I'm not sure if this alias is even needed, I couldn't find any references to changeCurDir in std.

For dependsOnSystemLibrary, it looks like because of the way it finds dependency libraries, compile can't be a *const Compile. And since Module::link_libc returns a ?bool with null meaning "doesn't matter", I used best judgement and assigned it to false based on how is_linking_libc is being used.

@andrewrk andrewrk merged commit 0d6b17b into ziglang:master Jan 21, 2025
10 checks passed
@andrewrk
Copy link
Member

Thanks!

github-actions bot pushed a commit to 5hes/zig that referenced this pull request Jan 22, 2025
This reverts commit 0d6b17b, reversing
changes made to 0ec6b2d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants