Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Value: implement orderAgainstZeroInner for errors #22328

Merged
merged 1 commit into from
Dec 29, 2024
Merged

Value: implement orderAgainstZeroInner for errors #22328

merged 1 commit into from
Dec 29, 2024

Conversation

Rexicon226
Copy link
Contributor

closes #22287

@pavelverigo
Copy link
Contributor

pavelverigo commented Dec 27, 2024 •
edited
Loading

I am 0.95 sure, that zig error is always positive integer, so it should be just => .gt? I did similar change in #21450 with CI passing.

@Rexicon226
Copy link
Contributor Author

Erm yeah, good point, I rely on similar behavior in the RISC-V backend. Good catch.

@andrewrk andrewrk merged commit b99dbb6 into ziglang:master Dec 29, 2024
10 checks passed
@Rexicon226 Rexicon226 deleted the err-switch-continue branch December 29, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

trace trap (core dumped) on continue inside error switch
3 participants
@Rexicon226 @pavelverigo @andrewrk