Test array with same elements. Test fails #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve issue #4
In case the height argument is provided along with an array filled by the same number, check out the graph plotted: it has
height == 1. It makes sense, because if you want to plot:[4, 4, 4, 4], it makes sense to have a chart with a straight line: it's height will be 1.But sinse a height is provided as param, I'd expect the chart to be filled with a eg 4 blank lines above and 5 lines below. Or maybe 9 lines above and 0 lines below? I don't know. I'll let it as it is and you can make the call on how do you want it.
Maybe a follow up task could be: add a new param to fill padding top and bottom of the graph, and use that new function to add padding to a graph that has drawn an array with same values and a height as param.