Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CO-1377: message / conversation preview in focus-mode #810

Draft
wants to merge 15 commits into
base: devel
Choose a base branch
from
Draft

CO-1377: message / conversation preview in focus-mode #810

wants to merge 15 commits into from
+224 −70

Conversation

mbarto
Copy link
Contributor

@mbarto mbarto commented Feb 24, 2025

No description provided.

@mbarto mbarto force-pushed the CO-1377-fix-pdf-preview-in-extra-window-focus-mode branch from 2516ff8 to 6775846 Compare February 24, 2025 14:01
@mbarto
Copy link
Contributor Author

mbarto commented Mar 20, 2025

We need to check how to correctly handle eml attachments before merging

@drazen04 drazen04 force-pushed the CO-1377-fix-pdf-preview-in-extra-window-focus-mode branch from 7951637 to 7b67a1f Compare March 25, 2025 15:24
@CLAassistant
Copy link

CLAassistant commented Mar 25, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@drazen04 drazen04 force-pushed the CO-1377-fix-pdf-preview-in-extra-window-focus-mode branch 2 times, most recently from 189a65f to 4ac6f0d Compare March 27, 2025 17:14
mbarto and others added 15 commits March 31, 2025 15:33
@mbarto @drazen04
feat(CO-1377): added focus-mode route to display message/conversation…
48349d2 
… in extra window
@mbarto @drazen04
feat(CO-1377): switched msg preview (for messages and conversations) …
b89c21b 
…to use focus-mode preview
@mbarto @drazen04
feat: added tests for StandalonePreviewPanel
e6d71c1
@mbarto @drazen04
feat: added more tests for StandalonePreviewPanel
2f5f2ec
@mbarto @drazen04
chore: added more tests
0f10261
@drazen04
fix: use 'useLocation' instead of 'useRouteMatch'
0e49f9c
@drazen04
fix: use 'Routes' instead of 'Switch'
765ffac
@drazen04
chore: no need of useLocation. Routes should handle
8948668
@drazen04
remove params where calling component cause useParam is dynamic
b065dcc
@drazen04
wip: check that params are not undefined to pass type check
55dd889
@drazen04
remove unused conversationPreviewFactory
43f0330
@drazen04
fix import
39701bf
@drazen04
refactor: using one Route for conversation, one for message + use Mes…
0b0558d 
…sagePreviewContainer
@drazen04
fix: use fallback in case folderId is undefined
7f2beeb
@drazen04
todo: remove useless component when tests are fixed
b7d9c6a
@drazen04 drazen04 force-pushed the CO-1377-fix-pdf-preview-in-extra-window-focus-mode branch from 4ac6f0d to b7d9c6a Compare March 31, 2025 13:33
@sonarqube-zextras Sonarqube Zextras
Copy link

Failed Quality Gate failed

  • 77.30% Coverage on New Code (is less than 80.00%)
  • 2 New Issues (is greater than 0)

Project ID: carbonio-mails-ui

View in SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mbarto @CLAassistant @drazen04