Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 29 multi yaml add type part1 #125

Merged
merged 6 commits into from
Aug 22, 2024
Merged

Conversation

amerharb
Copy link
Collaborator

in this part1 of issue 29
more or less this is just a refactor before actual solution

  • add types
  • save the source file (yaml file) for each message id where it comes from

Later in next PR:
messages will be saved in its original file currently all saved in one file

@amerharb amerharb marked this pull request as draft August 19, 2024 07:33
@amerharb amerharb marked this pull request as ready for review August 19, 2024 09:39
@WULCAN
Copy link
Collaborator

WULCAN commented Aug 21, 2024

Except for the tiny review finding above, it's all good. Thank you!

@amerharb amerharb requested a review from WULCAN August 22, 2024 09:36
@WULCAN WULCAN merged commit dcb6fe5 into main Aug 22, 2024
2 checks passed
@WULCAN WULCAN deleted the issue-29-multi-yaml-add-type-part1 branch August 22, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants