Skip to content

Commit

Permalink
- Undelete.
Browse files Browse the repository at this point in the history
  • Loading branch information
sebastianbergmann committed Jun 3, 2008
1 parent decd4cf commit f63b0f4
Showing 1 changed file with 18 additions and 0 deletions.
18 changes: 18 additions & 0 deletions review-1.2.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
[ ] ezcWorkflowDefinitionStorageXml mentions a @todo: DTD for the XML file.

See http://issues.ez.no/IssueView.php?Id=13130.

[X] Listeners or plugins are not mentioned in the tutorial.

[X] The class docs for ezcWorkflowExecutionListenerPlugin and
ezcWorkflowExecutionVisualizerPlugin need an example on how they can be used.

[X] Why is ezcWorkflowExecution::endThread marked with @ignore? As well as some
other methods in this class?

These methods are marked with @ignore as they are never to be called
by the developer that uses the component(s). They are declared public
because other classes of the component(s) need access to them.

[X] There is only 95.54% code coverage when running just the Workflow tests.
Especially the listener doesn't seem to have any direct tests.

0 comments on commit f63b0f4

Please sign in to comment.