refactor: omit unnecessary reassignment

e2e/e2etests/legacy/test_rate_limiter.go

@@ -109,7 +109,6 @@ func createAndWaitWithdraws(r *runner.E2ERunner, withdrawType withdrawType, with
 	g, ctx := errgroup.WithContext(r.Ctx)
 	for i, tx := range txs {
 		// capture the loop variables
-		tx, i := tx, i
 
 		// start a goroutine to wait for the withdraw to be mined
 		g.Go(func() error {

e2e/e2etests/test_stress_sui_deposit.go

@@ -25,7 +25,6 @@ func TestStressSuiDeposit(r *runner.E2ERunner, args []string) {
 	// send the SUI deposit transactions
 	for i := range numDeposits {
 		// each goroutine captures its own copy of i
-		i := i
 		resp := r.SuiDepositSUI(r.SuiGateway.PackageID(), r.EVMAddress(), math.NewUintFromBigInt(amount))
 
 		r.Logger.Print("index %d: started with tx hash: %s", i, resp.Digest)

e2e/e2etests/test_stress_sui_withdraw.go

@@ -44,7 +44,6 @@ func TestStressSuiWithdraw(r *runner.E2ERunner, args []string) {
 	revertOptions := gatewayzevm.RevertOptions{OnRevertGasLimit: big.NewInt(0)}
 	for i := range numWithdrawals {
 		// each goroutine captures its own copy of i
-		i := i
 		tx := r.SuiWithdraw(signer.Address(), amount, r.SUIZRC20Addr, revertOptions)
 
 		// wait for receipt before next withdrawal to avoid race condition

e2e/utils/zetacore.go

@@ -141,7 +141,6 @@ func WaitCctxsMinedByInboundHash(
 		cctxs = make([]*crosschaintypes.CrossChainTx, 0, len(res.CrossChainTxs))
 		allFound := true
 		for j, cctx := range res.CrossChainTxs {
-			cctx := cctx
 			if !cctx.CctxStatus.Status.IsTerminal() {
 				// prevent spamming logs
 				if i%20 == 0 {

pkg/chains/chain_test.go

@@ -236,7 +236,6 @@ func TestChain_EncodeAddress(t *testing.T) {
 	}
 
 	for _, tc := range tests {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			s, err := tc.chain.EncodeAddress(tc.b)
 			if tc.wantErr {

pkg/os/path_test.go

@@ -39,7 +39,6 @@ func TestResolveHome(t *testing.T) {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			pathOut, err := zetaos.ExpandHomeDir(tc.pathIn)
 			require.NoError(t, err)
@@ -74,7 +73,6 @@ func TestFileExists(t *testing.T) {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			exists := zetaos.FileExists(tc.file)
 			require.Equal(t, tc.expected, exists)

x/crosschain/genesis.go

@@ -70,21 +70,18 @@ func ExportGenesis(ctx sdk.Context, k keeper.Keeper) *types.GenesisState {
 	// Get all gas prices
 	gasPriceList := k.GetAllGasPrice(ctx)
 	for _, elem := range gasPriceList {
-		elem := elem
 		genesis.GasPriceList = append(genesis.GasPriceList, &elem)
 	}
 
 	// Get all last block heights
 	lastBlockHeightList := k.GetAllLastBlockHeight(ctx)
 	for _, elem := range lastBlockHeightList {
-		elem := elem
 		genesis.LastBlockHeightList = append(genesis.LastBlockHeightList, &elem)
 	}
 
 	// Get all send
 	sendList := k.GetAllCrossChainTx(ctx)
 	for _, elem := range sendList {
-		elem := elem
 		genesis.CrossChainTxs = append(genesis.CrossChainTxs, &elem)
 	}
 

x/crosschain/keeper/abci_test.go

@@ -192,7 +192,6 @@ func Test_CheckAndUpdateCCTXGasPrice(t *testing.T) {
 		},
 	}
 	for _, tc := range tt {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			// ARRANGE
 			k, ctx := testkeeper.CrosschainKeeperAllMocks(t)
@@ -405,7 +404,6 @@ func Test_CheckAndUpdateCCTXGasPriceEVM(t *testing.T) {
 		},
 	}
 	for _, tc := range tt {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			// ARRANGE
 			k, ctx := testkeeper.CrosschainKeeperAllMocks(t)
@@ -572,7 +570,6 @@ func Test_CheckAndUpdateCCTXGasPriceBTC(t *testing.T) {
 		},
 	}
 	for _, tc := range tt {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			// ARRANGE
 			k, ctx := testkeeper.CrosschainKeeperAllMocks(t)
@@ -747,7 +744,6 @@ func Test_IsCCTXGasPriceUpdateSupported(t *testing.T) {
 	}
 
 	for _, tc := range tt {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			isSupported := keeper.IsCCTXGasPriceUpdateSupported(tc.chainID, []chains.Chain{})
 			require.Equal(t, tc.isSupport, isSupported)

x/crosschain/keeper/cctx_test.go

@@ -128,7 +128,6 @@ func TestCCTXs(t *testing.T) {
 		},
 	}
 	for _, tt := range cctxsTest {
-		tt := tt
 		t.Run(tt.TestName, func(t *testing.T) {
 			keeper, ctx, _, zk := keepertest.CrosschainKeeper(t)
 			keeper.SetZetaAccounting(ctx, types.ZetaAccounting{AbortedZetaAmount: math.ZeroUint()})
@@ -227,7 +226,6 @@ func TestCCTXQuerySingle(t *testing.T) {
 			err:  status.Error(codes.InvalidArgument, "invalid request"),
 		},
 	} {
-		tc := tc
 		t.Run(tc.desc, func(t *testing.T) {
 			response, err := keeper.Cctx(wctx, tc.request)
 			if tc.err != nil {

x/crosschain/keeper/grpc_query_gas_price_test.go

@@ -49,7 +49,6 @@ func TestGasPriceQuerySingle(t *testing.T) {
 			err:     fmt.Errorf("strconv.Atoi: parsing \"abc\": invalid syntax"),
 		},
 	} {
-		tc := tc
 		t.Run(tc.desc, func(t *testing.T) {
 			response, err := k.GasPrice(wctx, tc.request)
 			if tc.err != nil {

x/crosschain/keeper/grpc_query_last_block_height_test.go

@@ -44,7 +44,6 @@ func TestLastBlockHeightQuerySingle(t *testing.T) {
 			err:  status.Error(codes.InvalidArgument, "invalid request"),
 		},
 	} {
-		tc := tc
 		t.Run(tc.desc, func(t *testing.T) {
 			response, err := k.LastBlockHeight(wctx, tc.request)
 			if tc.err != nil {

x/crosschain/keeper/msg_server_vote_inbound_tx_test.go

@@ -308,7 +308,6 @@ func TestStatus_UpdateCctxStatus(t *testing.T) {
 		},
 	}
 	for _, test := range tt {
-		test := test
 		t.Run(test.Name, func(t *testing.T) {
 			test.Status.UpdateStatusAndErrorMessages(test.NonErrStatus, types.StatusMessages{StatusMessage: test.Msg})
 			if test.IsErr {

x/crosschain/keeper/msg_server_vote_outbound_tx_test.go

@@ -93,7 +93,6 @@ func TestKeeper_FundGasStabilityPoolFromRemainingFees(t *testing.T) {
 	}
 
 	for _, tc := range tt {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			k, ctx := keepertest.CrosschainKeeperAllMocks(t)
 			fungibleMock := keepertest.GetCrosschainFungibleMock(t, k)

x/crosschain/simulation/decoders_test.go

@@ -75,7 +75,6 @@ func TestDecodeStore(t *testing.T) {
 	}
 
 	for i, tt := range tests {
-		i, tt := i, tt
 		t.Run(tt.name, func(t *testing.T) {
 			require.Equal(t, tt.expectedLog, dec(kvPairs.Pairs[i], kvPairs.Pairs[i]))
 		})

x/emissions/simulation/decoders_test.go

@@ -40,7 +40,6 @@ func TestDecodeStore(t *testing.T) {
 	}
 
 	for i, tt := range tests {
-		i, tt := i, tt
 		t.Run(tt.name, func(t *testing.T) {
 			require.Equal(t, tt.expectedLog, dec(kvPairs.Pairs[i], kvPairs.Pairs[i]))
 		})

x/fungible/keeper/evm_hooks_test.go

@@ -96,7 +96,6 @@ func TestKeeper_CheckPausedZRC20(t *testing.T) {
 	}
 
 	for _, tc := range tt {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			k, ctx, _, _ := keepertest.FungibleKeeper(t)
 

x/fungible/simulation/decoders_test.go

@@ -35,7 +35,6 @@ func TestDecodeStore(t *testing.T) {
 	}
 
 	for i, tt := range tests {
-		i, tt := i, tt
 		t.Run(tt.name, func(t *testing.T) {
 			require.Equal(t, tt.expectedLog, dec(kvPairs.Pairs[i], kvPairs.Pairs[i]))
 		})

x/fungible/types/message_pause_zrc20_test.go

@@ -74,7 +74,6 @@ func TestMsgPauseZRC20_ValidateBasic(t *testing.T) {
 		},
 	}
 	for _, tc := range tt {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			err := tc.msg.ValidateBasic()
 			if tc.wantErr {

x/fungible/types/message_unpause_zrc20_test.go

@@ -74,7 +74,6 @@ func TestMsgUnpauseZRC20_ValidateBasic(t *testing.T) {
 		},
 	}
 	for _, tc := range tt {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			err := tc.msg.ValidateBasic()
 			if tc.wantErr {

x/observer/genesis.go

@@ -144,7 +144,6 @@ func ExportGenesis(ctx sdk.Context, k keeper.Keeper) *types.GenesisState {
 	nodeAccountList := k.GetAllNodeAccount(ctx)
 	nodeAccounts := make([]*types.NodeAccount, len(nodeAccountList))
 	for i, elem := range nodeAccountList {
-		elem := elem
 		nodeAccounts[i] = &elem
 	}
 

x/observer/keeper/grpc_query_node_account_test.go

@@ -44,7 +44,6 @@ func TestNodeAccountQuerySingle(t *testing.T) {
 			err:  status.Error(codes.InvalidArgument, "invalid request"),
 		},
 	} {
-		tc := tc
 		t.Run(tc.desc, func(t *testing.T) {
 			response, err := k.NodeAccount(wctx, tc.request)
 			if tc.err != nil {

x/observer/keeper/grpc_query_nonces_test.go

@@ -47,7 +47,6 @@ func TestChainNoncesQuerySingle(t *testing.T) {
 			err:  status.Error(codes.InvalidArgument, "invalid request"),
 		},
 	} {
-		tc := tc
 		t.Run(tc.desc, func(t *testing.T) {
 			response, err := k.ChainNonces(wctx, tc.request)
 			if tc.err != nil {

x/observer/keeper/grpc_query_tss_test.go

@@ -44,7 +44,6 @@ func TestTSSQuerySingle(t *testing.T) {
 			response: &types.QueryGetTSSResponse{TSS: tss},
 		},
 	} {
-		tc := tc
 		t.Run(tc.desc, func(t *testing.T) {
 			if !tc.skipSettingTss {
 				k.SetTSS(ctx, tss)
@@ -81,7 +80,6 @@ func TestTSSQueryHistory(t *testing.T) {
 			err:           nil,
 		},
 	} {
-		tc := tc
 		t.Run(tc.desc, func(t *testing.T) {
 			tssList := sample.TssList(tc.tssCount)
 			for _, tss := range tssList {

x/observer/simulation/decoders_test.go

@@ -103,7 +103,6 @@ func TestNewDecodeStore(t *testing.T) {
 	}
 
 	for i, tt := range tests {
-		i, tt := i, tt
 		t.Run(tt.name, func(t *testing.T) {
 			require.Equal(t, tt.expectedLog, dec(kvPairs.Pairs[i], kvPairs.Pairs[i]))
 		})

x/observer/types/ballot_test.go

@@ -259,7 +259,6 @@ func TestBallot_AddVote(t *testing.T) {
 		},
 	}
 	for _, test := range tt {
-		test := test
 		t.Run(test.name, func(t *testing.T) {
 			ballot := Ballot{
 				Index:            "index",
@@ -396,7 +395,6 @@ func TestBallot_IsFinalizingVote(t *testing.T) {
 		},
 	}
 	for _, test := range tt {
-		test := test
 		t.Run(test.name, func(t *testing.T) {
 
 			ballot := Ballot{
@@ -733,7 +731,6 @@ func Test_BuildRewardsDistribution(t *testing.T) {
 			},
 		}}
 	for _, test := range tt {
-		test := test
 		t.Run(test.name, func(t *testing.T) {
 			result := BuildRewardsDistribution(test.ballotList)
 			require.Equal(t, test.expectedMap, result)