Skip to content

[Content] Notify users when a related item failed to publish due to missing an allow publish status #3540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

finnar-bin
Copy link
Contributor

Show a notification to let users know when a related content item failed to publish due to missing an allow publish workflow status
Resolves #3539

Content---nar-test-2---Zesty-io---zesty-pw---Manager.webm

@finnar-bin finnar-bin self-assigned this May 23, 2025
@finnar-bin finnar-bin added bug Something isn't working ready PR is complete and ready for deployment labels May 23, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a notification to inform users when any related content items fail to publish due to missing the required workflow status.

  • Captures publishing results via Promise.allSettled
  • Filters responses for 403 errors on related items
  • Dispatches an error notification listing the affected item titles
Comments suppressed due to low confidence (2)

src/apps/content-editor/src/app/views/ItemEdit/components/ItemEditHeader/ItemEditHeaderActions.tsx:334

  • [nitpick] Fix grammar in the error message: change "does not have" to "do not have" when referring to multiple items.
"The following related items does not have the required status that allows publishing: ${relatedItemsWithMissingPublishStatus.join(

src/apps/content-editor/src/app/views/ItemEdit/components/ItemEditHeader/ItemEditHeaderActions.tsx:289

  • [nitpick] The variable publishResponse holds an array of results. Rename it to publishResponses or publishResults for clarity.
const publishResponse = await Promise.allSettled([

@finnar-bin finnar-bin marked this pull request as draft May 27, 2025 22:39
@finnar-bin
Copy link
Contributor Author

finnar-bin commented May 27, 2025

Temporarily placing on hold as we need to request for a change on the api to provide a clearer error message instead of assuming that the 403 was caused by a missing workflow status

@finnar-bin finnar-bin added blocked and removed ready PR is complete and ready for deployment labels May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content - No error message when publishing related one-to-one/many content item without allow publish status
1 participant